? Error

User tests: Successful: Unsuccessful:

avatar klas
klas
7 Nov 2013

Joomla 2.5 output

<input type="text" size="30" class="inputbox required" value="" id="jform_title" name="jformtitle" aria-required="true" required="required">

3.2. after recent changes

<input type="text" size="30" class="inputbox" value="" id="jform_title" name="jformtitle">

The above patch adds required back for fields that are marked required

avatar klas klas - open - 7 Nov 2013
avatar mbabker
mbabker - comment - 7 Nov 2013

This shouldn't be required I think based on what's in getLabel(). Think you can look to see why that line isn't working?

avatar klas
klas - comment - 7 Nov 2013

getlabel adds class to the label, but mootols validate.js only looks in the input fields. - https://github.com/klas/joomla-cms/blob/0c8effd77dbf2f120416363583cab0154731d3da/media/system/js/validate-uncompressed.js#L72

Validate will work for those extensions using jquery validation, but not for those still on mootols version, also a lot of older custom validators work on inputs, so to maintain backwards compatibility required class should be added to inputs until mootols is supported.

avatar mbabker
mbabker - comment - 7 Nov 2013

Thanks for the info.

avatar brianteeman
brianteeman - comment - 10 Nov 2013

Thanks for your contribution - At this time we are only using github as the place to submit code fixes, the actual reporting of issues and testing fixes is still taking place on Joomlacode.

Please can you:

1) Open an item on the Joomlacode tracker in the appropriate area.

CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103

CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549

2) After submitting the item to the Joomlacode tracker, add a link to the Joomlacode tracker item here and make sure that you add a link to this GitHub issue or pull request on the joomlacode tracker item.

avatar wilsonge
wilsonge - comment - 26 Jul 2014

This has been superseded by #2690 which has updated it to the new JForm code in 3.2. Thanks for your contribution!

avatar brianteeman brianteeman - close - 26 Jul 2014

Add a Comment

Login with GitHub to post a comment