[#24326] - [4.0] Show Password
- Closed
- 6 Nov 2019
- Medium
- Build: 4.0-dev
- # 24326
- Diff
- maliouris:show-pass
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Failure continuous-integration/drone/pr the build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
#24312
Summary of Changes
Make eye icon on login forms accessible. Change it from span to input. Addittionally sr-only text now changes if password is seen or not.
Testing Instructions
Go to a login form, for example admin login form and try to select icon eye with keyboard
Expected result
Navigate through the forms with tabs
Actual result
Skip eye icon as it is span
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration Templates (admin) JavaScript Repository NPM Change Front End Templates (site) |
Is it ok now ?
| Labels |
Added:
NPM Resource Changed
?
|
||
As far as I saw your pull request didnt make it to the main branch because it was a custom element. Am I wrong? If I have to make a custom element I can close this pull request and prepare a new one.
franz-wohlkoenig
- | Category | Modules Administration Templates (admin) JavaScript Repository NPM Change Front End Templates (site) | ⇒ | Administration Front End JavaScript Modules Repository Templates (admin) Templates (site) |
| Title |
|
||||||
| Category | Modules Administration Templates (admin) JavaScript Repository Front End Templates (site) | ⇒ | Modules Administration Templates (admin) JavaScript Repository NPM Change Front End Templates (site) |
I have tested this item
Meanwhile we have a button after the span in Joomla, so it is solved already.
So it is accessible via keyboard and the PR has a conflict, missing bootstrap.scss
PR should be closed ;)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24326.
I have tested this item unsuccessfully on 23977f1
Meanwhile we have a button after the span in Joomla, so it is solved already.
So it is accessible via keyboard and the PR has a conflict, missing bootstrap.scss
PR should be closed ;)This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24326.
Thats partly true, the mod_login is not support this feature. if we don't get a response from @maliouris within 2 week we should close this pr and create a new one.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-06 04:03:15 |
| Closed_By | ⇒ | Quy |
Closing due to no response.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24326.
Please edit your post to indicate exactly what the problem is, what you have changed and how to test that this has fixed the problem.