Feeling Lucky
J3 Issue
?
[#24306] - fixes Titles in the Admin Page
- Closed
- 5 May 2019
- Medium
- Build: 4.0-dev
- # 24306
- Diff
- meet2410shah:4.0-dev
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #24304
Summary of Changes
administrator\templates\atum\html\module.php
Testing Instructions
go to /administrator/index.php
Expected result
Titles in the main content are aligned center.
Actual result
Previously titles are aligned left which affects user experience.
Documentation Changes Required
if ($module->showtitle)
{
echo '<h2 style="display:flex; justify-content:center" class="card-header' . $headerClass . '">' . $module->title . '</h2>';
}
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration Templates (admin) Modules Front End Templates (site) JavaScript |
brianteeman
- comment
- 22 Mar 2019
- This PR includes a lot of unrelated changes
- Using an inline style is not the best way
- changing from left/right aligned to center aligned is a design issue
| Labels |
Added:
?
|
||
C-Lodder
- comment
- 22 Mar 2019
Your issue mentions that the title being left aligned affects the user experience. Do you have any evidence to back this up? Why should it be aligned to the center?
| Title |
|
||||||
brianteeman
- comment
- 5 May 2019
This should be closed for the reasons stated above
franz-wohlkoenig
- comment
- 5 May 2019
Closed as stated by @brianteeman
| Closed_By | Quy | ⇒ | joomla-cms-bot |
Quy
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-05 11:25:36 |
| Closed_By | ⇒ | Quy |
joomla-cms-bot
- comment
- 5 May 2019
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24306
Please give the Pull Request a more meaningful Title like the issue.