Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24303] - [4.0][plg_system_stats] Add script to HTML documents only

? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
22 Mar 2019

Pull Request for Issue #24300.

Summary of Changes

Adds a check for document type.

Testing Instructions

Clean install of 4.0-dev nightly.
Login to backend.

Expected result

No errors.

Actual result


An error has occurred.

    0 Call to a member function addScript() on null

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 22 Mar 2019
avatar SharkyKZ SharkyKZ - change - 22 Mar 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2019
Category ⇒ Front End Plugins
avatar SharkyKZ SharkyKZ - change - 22 Mar 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 22 Mar 2019
avatar infograf768
infograf768 - comment - 22 Mar 2019

I have tested this item ✅ successfully on 679de54

Solves that specific issue.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24303.

avatar infograf768 infograf768 - test_item - 22 Mar 2019 - Tested successfully
avatar rdeutz
rdeutz - comment - 22 Mar 2019

Seems to be a fix for the problem, I am going to include this into my PR about fixing tests, so that we are back on green

avatar rdeutz
rdeutz - comment - 22 Mar 2019

closed in favor of #24309, Thanks @SharkyKZ

avatar rdeutz rdeutz - close - 22 Mar 2019
avatar rdeutz rdeutz - change - 22 Mar 2019
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-03-22 09:13:47
Closed_By ⇒ rdeutz
Labels Added: ?

Add a Comment

Login with GitHub to post a comment