Feeling Lucky
J4 Issue
?
[#24302] - [4.0] Warning and Notice when Installing language pack
- Closed
- 15 Dec 2019
- Medium
- Build: master
- # 24302
Steps to reproduce the issue
Go to administrator/index.php?option=com_installer&view=languages
Install French (fr-FR) or German (de-DE) languages
- We get a Notice
There were no checksums provided in the package. - We get a PHP warning
[22-Mar-2019 09:02:29 Europe/Berlin] PHP Warning: Creating default object from empty value in ~/libraries/src/Updater/Update.php on line 299
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
J4 Issue
|
||
franz-wohlkoenig
- | Status | New | ⇒ | Discussion |
| Category | ⇒ | com_languages |
infograf768
- comment
- 22 Mar 2019
Concerning 1) I did understand this has been implemented, but how shall we do to add a checksum for language packs?
alikon
- comment
- 22 Mar 2019
a perfect example can be like com_patchtester do it
https://github.com/joomla-extensions/patchtester/blob/master/build/patchtester/build.sh#L19
even core do it https://github.com/joomla/update.joomla.org/blob/master/www/core/sts/extension_sts.xml#L184
- calculate the hash of the pkg/zip
- add the hash to the pkg manifest
we need to find a "good " way to do it in an "easy way" for the language release cycle too
brianteeman
- comment
- 13 Dec 2019
I can not replicate this
infograf768
- comment
- 15 Dec 2019
Indeed, we do not have this anymore.
Closing.
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-15 07:34:31 |
| Closed_By | ⇒ | infograf768 |
the 1) should be OK see #17619 & #17555 (gsoc 2017) in 4.x every install pkg should have at least a checksum
for 2) i'll investigate later