Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24276] - [4.0] Fix disable and enable buttons

NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar maliouris
maliouris
21 Mar 2019

Pull Request for Issue # .

Summary of Changes

Remove connectedCallback() call from the constructor as it might cause some issues later and moved a part of code from the costructor to the connectedCallback() function in order to disable buttons properly

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar maliouris maliouris - open - 21 Mar 2019
avatar maliouris maliouris - change - 21 Mar 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2019
Category ⇒ JavaScript Repository NPM Change
avatar infograf768
infograf768 - comment - 21 Mar 2019

Please solve conflicting file

avatar maliouris maliouris - change - 21 Mar 2019
Title
…
4.0 dev
[4.0] Fix disable and enable buttons
avatar maliouris maliouris - edited - 21 Mar 2019
avatar maliouris maliouris - change - 21 Mar 2019
Labels Added: NPM Resource Changed ?
avatar infograf768
infograf768 - comment - 21 Mar 2019

@Fedik
is that one OK?

avatar Fedik
Fedik - comment - 21 Mar 2019

yes that looks good ?

avatar wilsonge wilsonge - change - 21 Mar 2019
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-03-21 13:25:57
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 21 Mar 2019
avatar wilsonge wilsonge - merge - 21 Mar 2019
avatar wilsonge
wilsonge - comment - 21 Mar 2019

Awesome stuff! Thankyou very much!

Add a Comment

Login with GitHub to post a comment