User tests: Successful: Unsuccessful:
Pull Request for Issue #24182 .
Existing code only removes immediate previous select
Clear Cache
1 ordering only
Ordering unexpectedly adds
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript |
Labels |
Added:
?
|
Title |
|
please the last PR making changes to this file https://github.com/joomla/joomla-cms/pull/23052/files
there you see that $el.chosen('destroy') has been used, plz try this.
@HLeithner Tried replacing .remove() with .chosen('destroy') but it's not working
I think you have to use:
$("#" + $id).chosen('destroy');
or simply try to restore the old version
var $el = $("#" + $id);
if ($el) {
$el.chosen('destroy');
$el.chosen();
}
I think you have to use:
$("#" + $id).chosen('destroy');
I tried with this only. Will try with $el, but reverting it might bring back the issue due to which it was removed.
var $el = $("#" + $id); if ($el) { $el.chosen('destroy'); $el.chosen(); }
@HLeithner I tried to undo the changes made in https://github.com/joomla/joomla-cms/pull/23052/files, but it doesn't solve the issue and might bring back #22935. Also, is there something wrong in the solution I implemented(.remove()
)?
if this works maybe its the correct way.
@infograf768 @HLeithner Kindly test this
I have tested this item
@HLeithner
Works fine here whether for site or admin modules.
shouldn't we need the uncompressed/compressed version ?
seams there was never a compressed version...
maybe it's time to do it
another Pr would be better, I would like to merge this tomorrow if we get a second test.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
Status | Ready to Commit | ⇒ | Pending |
Okay
@HLeithner @Fedik Updated, kindly test
@alikon and @infograf768 can I get new test from you? I would like to merge this for todays RC
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-02 15:06:32 |
Closed_By | ⇒ | HLeithner |
thx
Not sure if
_chzn
is particular for my system only or is valid in general.