? Pending

User tests: Successful: Unsuccessful:

avatar bahl24
bahl24
20 Mar 2019

Pull Request for Issue #24182 .

Summary of Changes

Existing code only removes immediate previous select

Testing Instructions

Clear Cache

Expected result

1 ordering only

Actual result

Ordering unexpectedly adds

avatar bahl24 bahl24 - open - 20 Mar 2019
avatar bahl24 bahl24 - change - 20 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2019
Category JavaScript
avatar bahl24 bahl24 - change - 20 Mar 2019
Labels Added: ?
avatar bahl24
bahl24 - comment - 20 Mar 2019

Not sure if _chzn is particular for my system only or is valid in general.

avatar bahl24 bahl24 - change - 20 Mar 2019
Title
[staging]remove all the previous select
[staging]remove all the previous select while changing module pos
avatar bahl24 bahl24 - edited - 20 Mar 2019
avatar HLeithner
HLeithner - comment - 20 Mar 2019

please the last PR making changes to this file https://github.com/joomla/joomla-cms/pull/23052/files

there you see that $el.chosen('destroy') has been used, plz try this.

avatar bahl24
bahl24 - comment - 20 Mar 2019

@HLeithner Tried replacing .remove() with .chosen('destroy') but it's not working

avatar HLeithner
HLeithner - comment - 20 Mar 2019

I think you have to use:
$("#" + $id).chosen('destroy');

or simply try to restore the old version

var $el = $("#" + $id);
if ($el) {	
  $el.chosen('destroy');
  $el.chosen();
}
avatar bahl24
bahl24 - comment - 20 Mar 2019

I think you have to use:
$("#" + $id).chosen('destroy');

I tried with this only. Will try with $el, but reverting it might bring back the issue due to which it was removed.

avatar bahl24
bahl24 - comment - 25 Mar 2019
var $el = $("#" + $id);
if ($el) {	
  $el.chosen('destroy');
  $el.chosen();
}

@HLeithner I tried to undo the changes made in https://github.com/joomla/joomla-cms/pull/23052/files, but it doesn't solve the issue and might bring back #22935. Also, is there something wrong in the solution I implemented(.remove())?

avatar HLeithner
HLeithner - comment - 25 Mar 2019

if this works maybe its the correct way.

avatar bahl24
bahl24 - comment - 31 Mar 2019

@infograf768 @HLeithner Kindly test this

avatar infograf768
infograf768 - comment - 31 Mar 2019
avatar infograf768
infograf768 - comment - 1 Apr 2019

I have tested this item successfully on 5c90dda


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24260.

avatar infograf768 infograf768 - test_item - 1 Apr 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 1 Apr 2019

@HLeithner
Works fine here whether for site or admin modules.

avatar alikon
alikon - comment - 1 Apr 2019

shouldn't we need the uncompressed/compressed version ?

avatar HLeithner
HLeithner - comment - 1 Apr 2019

seams there was never a compressed version...

avatar alikon
alikon - comment - 1 Apr 2019

maybe it's time to do it 🙂 or matter for another pr

avatar HLeithner
HLeithner - comment - 1 Apr 2019

another Pr would be better, I would like to merge this tomorrow if we get a second test.

avatar alikon
alikon - comment - 1 Apr 2019

I have tested this item successfully on 4667c8c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24260.

avatar alikon alikon - test_item - 1 Apr 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Apr 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Apr 2019

Status "Ready To Commit".

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Apr 2019
Status Ready to Commit Pending
avatar bahl24
bahl24 - comment - 1 Apr 2019

Okay

avatar bahl24
bahl24 - comment - 2 Apr 2019

@HLeithner @Fedik Updated, kindly test

avatar HLeithner
HLeithner - comment - 2 Apr 2019

@alikon and @infograf768 can I get new test from you? I would like to merge this for todays RC

avatar HLeithner HLeithner - change - 2 Apr 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-02 15:06:32
Closed_By HLeithner
avatar HLeithner HLeithner - close - 2 Apr 2019
avatar HLeithner HLeithner - merge - 2 Apr 2019
avatar HLeithner
HLeithner - comment - 2 Apr 2019

thx

Add a Comment

Login with GitHub to post a comment