? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
20 Mar 2019

Pull Request for Issue #24252 .

Summary of Changes

Implements an internal QR-Code generator instead of the google charts.

Testing Instructions

Activate the Google Authenticator 2FA plugin and set up 2FA for one user.

Expected result

QR-Code visible

Actual result

QR-Code broken

avatar bembelimen bembelimen - open - 20 Mar 2019
avatar bembelimen bembelimen - change - 20 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2019
Category JavaScript Front End Plugins
avatar brianteeman
brianteeman - comment - 20 Mar 2019

Thank you for such a speedy response. I will test his in the morning

avatar ReLater
ReLater - comment - 20 Mar 2019

I have tested this item successfully on 550ddf2

Before patch: No QR code.
After patch: QR code created.

I could not test if QR code is scannable and/or correct. Decide yourself if that's a successful test!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24255.

avatar ReLater ReLater - test_item - 20 Mar 2019 - Tested successfully
avatar bembelimen bembelimen - change - 20 Mar 2019
Labels Added: ?
avatar wilsonge
wilsonge - comment - 2 Apr 2019

For my own reference when it comes to J4 the library is https://github.com/kazuhikoarase/qrcode-generator/blob/master/js/package.json#L2

avatar HLeithner HLeithner - change - 2 Apr 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-02 14:59:40
Closed_By HLeithner
avatar HLeithner HLeithner - close - 2 Apr 2019
avatar HLeithner HLeithner - merge - 2 Apr 2019
avatar HLeithner
HLeithner - comment - 2 Apr 2019

thx

avatar deroderuiter
deroderuiter - comment - 9 Apr 2019

I installed 3.9.5 but the fix for the QR-Code for 2FA still does not work on my Joomla installation. Do I have do to something special to get it working again?

avatar HLeithner
HLeithner - comment - 9 Apr 2019

@deroderuiter strange I tested it again and it works for me, do you have a screenshot and could you create a new issue.

avatar deroderuiter
deroderuiter - comment - 9 Apr 2019

There is not much to show. In edit profile I choose the tab Two Factor Authentication, I scan the QR code with the Google Authenticator App on my smartphone and fill in the code and save the page. No error is displayed but the tow factor authentication is not activated.

avatar deroderuiter
deroderuiter - comment - 9 Apr 2019

I saw I remark of Phil Taylor that Google no longer provides a chart API for QR Code. It was actually deprecated in 2012 and turned off Completely on March 18,2019
My English i not so good and I don't know if I understood this correctly and if it is correct it could explain why 2FA doesn't work anymore.

avatar brianteeman
brianteeman - comment - 9 Apr 2019

if you see the qr code then the issue you refer to above is resolved as the qr code has been generated by different code

avatar deroderuiter
deroderuiter - comment - 9 Apr 2019

So probably I have an other problem?

Add a Comment

Login with GitHub to post a comment