Drone failing. Please correct the unwanted tabs (useless new line)

/drone/src/github.com/joomla/joomla-cms/build/media_source/system/js/joomla-toolbar-button.w-c.es6.js
  28:1  error  Unexpected tab character     no-tabs
  28:1  error  Trailing spaces not allowed  no-trailing-spaces

✖ 2 problems (2 errors, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

BTW, this works fine!

Sorry this is stil wrong. There should be a newline only without tab and spaces.

I corrected it directly. :)

Please do not modify anymore your maliouris:4.0-dev branch

Yeah sorry, I dont know why this happened

I have tested this item ✅ successfully on 2b0b305

Thank you!

restarted drone

I have tested this item ✅ successfully on 2b0b305

rtc

Thanks.

woh, that was fast and that is wrong 😄

Added the calling of connectedCallback in the constructor, because the buttonElement had undefined value.

the fix are wrong, connectedCallback are part of CE API called when element actually attached to DOM. it should not be called in constructor, it for sure introduce some more fancy bugs.

A proper fix is to find out why buttonElement not defined,
that something went wrong with #23767

I saw the changes that were made in the other pull request and as far as I can see this.buttonElement = this.querySelector('button, a'); was called in the constructor and after the change it was called in connectedCallback() with no usage at all. I moved it back to the constructor and it works properly now. Should I make a new pull request ?

@maliouris yes please

:)

@maliouris another possible way to fix is to move this part

    // If list selection is required, set button to disabled by default
    if (this.listSelection) {
      this.setDisabled(true);
    }

to connectedCallback, somwhere after this.buttonElement = ...

Which one do you want think it's better?

second one, but need to test whether it will work

It worked for me