Language Change NPM Resource Changed PR-4.0-dev

Failure

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
6 Mar 2019

Summary of Changes

First approach of TinyMCE 4.x => 5.x migration.
Not everything is ready yet.

Testing Instructions

  • [IMPORTANT]: Apply #24211
  • Activate tinymce and create a new article
  • Test the tinymce builder option
avatar bembelimen bembelimen - open - 6 Mar 2019
avatar bembelimen bembelimen - change - 6 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Mar 2019
Category JavaScript Repository NPM Change Layout Front End Plugins
avatar brianteeman
brianteeman - comment - 6 Mar 2019

Awesome - To save some time in testing. When you say "not everything is ready" can you highlight what

avatar bembelimen
bembelimen - comment - 6 Mar 2019

I just tried to get the new version running, so stuff which has to be done (I guess the list is not complete):

  • the height is broken
  • the parameters needs a complete clean up
  • I would like to activate some features like "inline formatting" (when you select a text the small tooltip with the format options)
avatar dgrammatiko
dgrammatiko - comment - 7 Mar 2019

@bembelimen you need to do this as custom element as the rest of the fields

avatar C-Lodder
C-Lodder - comment - 7 Mar 2019

Nice.

Just an FYI, I think there is path in the plugin XML file allowing that's used for the skins directory. This might need updating too as you've added /ui to the other paths

avatar bembelimen bembelimen - change - 7 Mar 2019
Labels Added: NPM Resource Changed PR-4.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 7 Mar 2019
Category JavaScript Repository NPM Change Layout Front End Plugins Administration Language & Strings JavaScript Repository NPM Change Layout Front End Plugins
avatar bembelimen
bembelimen - comment - 7 Mar 2019

Just an FYI, I think there is path in the plugin XML file allowing that's used for the skins directory. This might need updating too as you've added /ui to the other paths

Yes, thanks, I updated it.

The next days I'll go through the parameters and fix this stuff. If someone want to help, feel free to submit a PR against my branch :)

avatar bembelimen bembelimen - change - 7 Mar 2019
Labels Added: Language Change
avatar zwiastunsw
zwiastunsw - comment - 8 Mar 2019

Is it possible to add an Accessibility Checker plugin?

avatar bembelimen
bembelimen - comment - 8 Mar 2019

Is it possible to add an Accessibility Checker plugin?

Do you have a link to one?

avatar zwiastunsw
zwiastunsw - comment - 8 Mar 2019
avatar bembelimen
bembelimen - comment - 8 Mar 2019

Thx, it seems that it is a paid plugin?

avatar brianteeman
brianteeman - comment - 8 Mar 2019

@zwiastunsw that plugin is neither free of cost or free to use

avatar zwiastunsw
zwiastunsw - comment - 9 Mar 2019

Sorry, in fact...

avatar dgrammatiko
dgrammatiko - comment - 10 Mar 2019

@bembelimen you do realise that the builder is based on a script (jQuery-ui) that is deprecated and marked for removal in J4? The builder needs to be redone based on dragula.js as the rest scripts in J4...

avatar Fedik
Fedik - comment - 10 Mar 2019

The builder needs to be redone

this is a separate task, no need to mix everything here,
to keep stuff simple and easier to test

avatar mrownicki
mrownicki - comment - 11 Mar 2019

Can you add Autosave plugin?
https://www.tiny.cloud/docs/plugins/autosave/

Full screen broken button joomla.

screen shot 2019-03-11 at 15 17 53


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24110.

avatar bembelimen
bembelimen - comment - 14 Mar 2019

@bembelimen you do realise that the builder is based on a script (jQuery-ui) that is deprecated and marked for removal in J4? The builder needs to be redone based on dragula.js as the rest scripts in J4...

Done

avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2019
Category JavaScript Repository NPM Change Layout Front End Plugins Administration Language & Strings Administration Front End JavaScript Language & Strings Layout Plugins Repository
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2019
Category JavaScript Repository Layout Front End Plugins Administration Language & Strings Administration Front End JavaScript Layout Plugins Repository
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2019
Category JavaScript Repository Layout Front End Plugins Administration Administration Language & Strings JavaScript Repository NPM Change Layout Front End Plugins
avatar bembelimen bembelimen - change - 13 Apr 2019
Labels Removed: J4 Issue
avatar bembelimen bembelimen - change - 16 Apr 2019
The description was changed
avatar bembelimen bembelimen - edited - 16 Apr 2019
avatar uglyeoin
uglyeoin - comment - 17 Apr 2019

When I use patchtester I get

The file marked for modification does not exist: build/build-modules-js/init.es6.js

avatar mbabker
mbabker - comment - 17 Apr 2019

com_patchtester does not work with anything that changes UI assets in 4.0 (anything in the build folder). If you see the "NPM Resource Changed" label on a pull request then don't waste your time trying.

avatar uglyeoin
uglyeoin - comment - 17 Apr 2019

@mbabker thank you. I assume it's not as simple as uploading the files to the right folder?

avatar mbabker
mbabker - comment - 17 Apr 2019

If you can get a copy of the compiled asset tree with the changes from this PR then you can upload that. But it's not as simple as uploading the build directory to a 4.0 installation.

avatar zwiastunsw
zwiastunsw - comment - 18 Apr 2019

Step 1. I'm downloading a copy of the branch from the Github of the author of the PR (for ex. https://github.com/bembelimen/joomla-cms/tree/tinymce-5.0)
Step 2. Next I unpacking in the document folder on a local server
Step 3. I'm running a Composer in this folder (composer install).
Step 4. I'm running a NPM in this folder (npm install)
Step 5. I'm installing Joomla

avatar wilsonge
wilsonge - comment - 18 Apr 2019

I have tested this item successfully on b3bfa55

Works for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24110.

avatar wilsonge
wilsonge - comment - 18 Apr 2019

I have tested this item successfully on b3bfa55

Works for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24110.

avatar wilsonge wilsonge - test_item - 18 Apr 2019 - Tested successfully
avatar wilsonge wilsonge - change - 18 Apr 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-18 13:01:31
Closed_By wilsonge
avatar wilsonge wilsonge - close - 18 Apr 2019
avatar wilsonge wilsonge - merge - 18 Apr 2019
avatar brianteeman
brianteeman - comment - 18 Apr 2019

Thank you @bembelimen

avatar wilsonge
wilsonge - comment - 18 Apr 2019

Indeed thankyou!

Add a Comment

Login with GitHub to post a comment