[#24106] - [4.0] Use namespaced version of JFactory everywhere
- Fixed in Code Base
- 15 Mar 2019
- Medium
- Build: 4.0-dev
- # 24106
- Diff
- C-Lodder:namespace-1
User tests: Successful: Unsuccessful:
Summary of Changes
Replace JFactory with Factory in all remaining files
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_content com_finder Repository CLI Front End |
| Labels |
Added:
?
|
||
| Category | Administration com_associations com_content com_finder Repository CLI Front End | ⇒ | Administration com_associations com_content Repository CLI Installation Libraries Front End Plugins Templates (site) |
Reverted com_finder
@amitranjan2 There's are loads of J prefixed classes that need changing. The PR focuses on solely on JFactory.
JText and the others can be done in separate PRs
Yes, I've changed all of the ones I found in a mass search, other than those in com_finder which I was asked to revert.
It would probably be much better creating a script that automatically does this.
Yes, I've changed all of the ones I found in a mass search, other than those in
com_finderwhich I was asked to revert.It would probably be much better creating a script that automatically does this.
that will be great,please create a script
that will be great,please create a script
There is no need for such a script, all modern IDEs offer search capabilities...
@dgrammatiko Not to just search for J prefixed classes, but to add use Joomla\xxx\xxx to the top of the file aswell
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24106.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24106.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24106.
| Title |
|
||||||
| Status | Pending | ⇒ | Ready to Commit | ||||
Status "Ready To Commit".
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-15 12:39:03 |
| Closed_By | ⇒ | wilsonge |
Thanks :)
Finder was excluded when I did the big namespace conversion as it was still being rewritten by @Hackwar and I believe he has recently done it with #24097