? Pending

User tests: Successful: Unsuccessful:

avatar coolcat-creations
coolcat-creations
6 Mar 2019

Fix language declaration. Has to be the first 2 letters and not en-Gb, de-DE .... etc.

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar coolcat-creations coolcat-creations - open - 6 Mar 2019
avatar coolcat-creations coolcat-creations - change - 6 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Mar 2019
Category Front End Plugins
avatar C-Lodder
C-Lodder - comment - 6 Mar 2019

According to Google, the region is optional and doesn't have to be 2 characters only.

avatar infograf768
infograf768 - comment - 6 Mar 2019

Please explain further what you want to achieve.

  1. Let's not forget that we may have language tags of type:
    ckb-IQ, prs-AF, etc
  2. A multilingual site may use en-GB AND en-US AND en-AU.
avatar infograf768
infograf768 - comment - 6 Mar 2019

Please close as this is breaking the hreflang for the cases above.

avatar infograf768
infograf768 - comment - 6 Mar 2019

@C-Lodder
Reminder: Concerning the "region" it was decided a long time ago that we would use country codes and never regions. Which means that we always have 2 letters for the country code.

avatar C-Lodder
C-Lodder - comment - 6 Mar 2019

@infograf768 Globally in Joomla or just in the language filter? Seems a bit silly considering languages have different dialects

avatar brianteeman
brianteeman - comment - 6 Mar 2019

Not sure what you are trying to achieve here but it looks like @infograf768 is correct

avatar infograf768
infograf768 - comment - 6 Mar 2019

Globally in Joomla or just in the language filter? Seems a bit silly considering languages have different dialects

Globally in Joomla and any CMS. Servers never consider regions (they may even not consider various country codes, depending on servers..)

We never consider dialects but languages and we do not use Extended Language Subtags.
It could be considered though in the future (for various variations of Chinese for example: zh-yue (Cantonese Chinese)).
I guess this would imply a few code changes. No one ever proposed such a pack until now.

See the mess here if we were for French (not taking into account that these provincial iso codes are never considered by any sotware...):
https://en.wikipedia.org/wiki/ISO_3166-2:FR

What you call a dialect may have a specific langage code:
Iraq country code may have
ar-IQ, ckb-IQ, kmr-IQ, sdh-IQ, etc.
Where the last 3 are variations of the Kurdish language.
https://en.wikipedia.org/wiki/Kurdish_languages

avatar infograf768
infograf768 - comment - 6 Mar 2019

Let's close this. If someone is interested in implementing Extended Language Subtags, please submit a PR.

avatar infograf768 infograf768 - close - 6 Mar 2019
avatar infograf768 infograf768 - change - 6 Mar 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-03-06 09:48:36
Closed_By infograf768
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 6 Mar 2019

@infograf768

Servers never consider regions

The hreflang tag is used by search engines to serve the right content to the right users. So I'm not sure how removing the dialect helps with that.

avatar infograf768
infograf768 - comment - 6 Mar 2019

@C-Lodder
I do not understand your comment.
Joomla never simplifies a lang tag of type xx-XX or xxx-XX in hreflang or elsewhere, and that is correct.

avatar C-Lodder
C-Lodder - comment - 6 Mar 2019

@infograf768 You say that Joomla never simplifies the lang and then said that Joomla doesn't use regions, but the -XX is the region

avatar infograf768
infograf768 - comment - 6 Mar 2019

I call this Country Codes, not regions.

avatar infograf768
infograf768 - comment - 6 Mar 2019

regions are Extended Language Subtags and we do not use them in Joomla.

Edit: Example
zh-yue (Cantonese Chinese)

avatar richard67
richard67 - comment - 6 Mar 2019

If you want to have 2 letter codes only, you can use the languagecode plugin.

avatar coolcat-creations
coolcat-creations - comment - 7 Mar 2019

Right thank you for taking care of this, I misunderstood the requirements.
It should be like that de and en for example is two letters only to be recognized by other countries that speak this language too - does not count for all languages. I will look into the languagecode plugin.

Add a Comment

Login with GitHub to post a comment