[#24081] - Update registration.php: Messages to unfinished actions should be warnings.
- Closed
- 21 May 2019
- Medium
- Build: staging
- # 24081
- Diff
- kofaysi:staging
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request fixes #23763.
Summary of Changes
Changed type of message from default (message) to warning.
Testing Instructions
Set administrator confirmation to required, when new users are registering.
- Register a new arbitrary user.
- Log out of all the Joomla frontend.
- Wait for the activation e-mail and activate the account by clicking on the link.
Expected result
A Warning (yellow) message appears. The action hasn't been accomplished yet. (Please log in to confirm that you are authorised to activate new accounts.)
Actual result
A green (successful event) message appears. The text is great and valid, but it is misleading about the event -- action has to be taken.
Documentation Changes Required
IDK about any
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24081.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24081.
| Labels |
Removed:
J3 Issue
|
||
| Category | Front End com_users | ⇒ | Administration com_contact Front End com_users |
Yes, I see that did mix them up. The bad thing is that I do not recall where did I make the mistake. (I remember I even deleted the forked repository to be sure that I'm PR-ing a single new suggestion.) The worse thing is that I do not know, how to correct the merge.
Simple PR to merge.
@kofaysi can you please resolve conflicting file so Release Lead @HLeithner can merge if he decide to?
I'm sorry, but I don't think it is possible in the web interface after I deleted the branch, isn't it?
(I learned from the issue and I'll be ignoring the "safe to deleted branch after creating a PR" notification and I'll be keeping all my branches named after the PR number until the PRs are closed.)
Since it is a minor change, close this PR and open a new PR.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-21 13:30:26 |
| Closed_By | ⇒ | franz-wohlkoenig |
I have tested this item✅ successfully on 8658030
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24081.