? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Mar 2019

This pr removes the sidebar from all the views previously accessed (in J3) from the extensions menu.

As in J4 they all have their own place in the system dashboard they can simply be removed

avatar brianteeman brianteeman - open - 4 Mar 2019
avatar brianteeman brianteeman - change - 4 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2019
Category Administration com_installer
avatar brianteeman brianteeman - change - 4 Mar 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2019
Category Administration com_installer Administration com_installer Language & Strings
avatar wilsonge
wilsonge - comment - 4 Mar 2019

Agree with this generally. Only question is do we need a back to system admin dashboard or are we happy with the browser back button?

avatar brianteeman
brianteeman - comment - 4 Mar 2019

@wilsonge i did think about that but figured it was beyond the scope of this pr as the same comment could be made about a lot of the links from the dashboard and i kind of hoped the secret template group might have already addressed that

avatar brianteeman
brianteeman - comment - 4 Mar 2019

@wilsonge Also I left the function addSubmenu in the code (but empty) I wasn't sure if it should be completely removed or not

avatar brianteeman brianteeman - change - 4 Mar 2019
Labels Added: ?
avatar flyingwombats flyingwombats - test_item - 7 Mar 2019 - Tested successfully
avatar flyingwombats
flyingwombats - comment - 7 Mar 2019

I have tested this item successfully on 673c791

Does as it says and removes the side menu in
Manage Extensions
Install Extensions
Update Extensions


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24080.

avatar Bodge-IT
Bodge-IT - comment - 9 Mar 2019

I have tested this item successfully on 673c791

Sidebar gone from extensions,discover & INSTALL LANG.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24080.

avatar Bodge-IT Bodge-IT - test_item - 9 Mar 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Mar 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Mar 2019

Status "Ready To Commit".

avatar wilsonge
wilsonge - comment - 18 Mar 2019

@wilsonge Also I left the function addSubmenu in the code (but empty) I wasn't sure if it should be completely removed or not

Kill it. It serves no purpose anymore

@wilsonge i did think about that but figured it was beyond the scope of this pr as the same comment could be made about a lot of the links from the dashboard and i kind of hoped the secret template group might have already addressed that

They've not touched com_installer. Some of the works gone into the public repo. and most the rest has in the private repo has been on the admin menu, dashboard and login screens

avatar brianteeman brianteeman - change - 18 Mar 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 18 Mar 2019

removed the function as requested

avatar wilsonge wilsonge - close - 21 Mar 2019
avatar wilsonge wilsonge - merge - 21 Mar 2019
avatar wilsonge wilsonge - change - 21 Mar 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-21 13:07:04
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 21 Mar 2019

Thanks!

avatar brianteeman
brianteeman - comment - 21 Mar 2019

Thanks

Add a Comment

Login with GitHub to post a comment