[#24062] - [4.0] Multilingual status: adding more infos and clarifying some
- Closed
- 30 Nov 2019
- Medium
- Build: 4.0-dev
- # 24062
- Diff
- infograf768:4.0_rfc_multilangstatus
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR adds a Notice and displays the language concerned when the Content Language for that language has been deleted and remains in the site an orphan home page while the site language is published.
It also adds a Notice when a Content Language is in the trash.
It also reinstate all states of a content language to display the correct icons.
published = 1
publsihed = 0
published = -2 (i.e. trash) and for this one displays the trash icon
Testing Instructions
Install a multilingual site with all languages available to install
French fr-FR
German de-DE
Persian fa-IR
Then use the Cpanel Multilingual Sample Data module to create a basic.
First test:
Display the Content languages Manager
Trash AND delete the fa-IR Persian content language.
You should get this when displaying the multilingual status module
Then unpublish the French fr-FR Content Language.
And trash (do NOT delete) the German de-DE Content language.
I.e. Manager should look like this
You should get this when displaying the multilingual status module
Edit
Unpublish also the fr-FR Home page to get a new notice.
Deleted Content Language error now displays the notice as last.
see #24062 (comment)
Reminder
It is OK to have an Unpublished Content Language (as French is above) as it lets the site owner prepare a new Language for the multilingual site.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_languages Language & Strings |
| Labels |
Added:
?
?
|
||
Added new Notice when both Content Language and Home page are unpublished.
The Published Default Home pages has all checks even though all pages are unpublished.
Added new Notice when both Content Language and Home page are unpublished.
The Published Default Home pages has all checks even though all pages are unpublished.
I do not understand this comment.
I don’t get the same result in the last column as in your last screenshot.
I don’t get the same result in your last screenshot.
Please explain with more details.
The exact settings you have for each language and the resulting screenshot.
I am no longer at my computer so it will have to wait until tomorrow. I followed all your testing instructions. Only the last screenshot that I did not get the same result. All pages are unpublished.
I may have forgotten to ask testing by unpublishing the French Home page AND its content language, in order to get the Notice and the right icons.
The order of the Notices may also have changed. One has to test multiple cases.
We may need though another Notice when site language is enabled, content language is published and home page is unpublished.
I.e. this case for French and German
On it.
Added notice when both content language and home page missing. added trash icon when home page is in the trash.
We now get in these cases:
Added warning icon when home page does not exist.
franz-wohlkoenig
- | Category | Administration com_languages Language & Strings | ⇒ | Administration com_languages |
| Category | Administration com_languages | ⇒ | Administration com_languages Language & Strings |
Please fix conflicts.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-30 07:48:41 |
| Closed_By | ⇒ | infograf768 |
@Quy
Modification done.
Added new Notice when both Content Language and Home page are unpublished.
We should now get in that case:
can be fully tested now.