? Pending

User tests: Successful: Unsuccessful:

avatar puneeth2001
puneeth2001
2 Mar 2019

Pull Request for Issue #24008

Summary of Changes

reordering(i.e. drag and drop enabled as required)

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar puneeth2001 puneeth2001 - open - 2 Mar 2019
avatar puneeth2001 puneeth2001 - change - 2 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2019
Category Administration com_content
avatar HLeithner HLeithner - change - 2 Mar 2019
Title
reordering done
[4.0] reordering done
avatar HLeithner HLeithner - edited - 2 Mar 2019
avatar HLeithner
HLeithner - comment - 2 Mar 2019

I'm not sure what are you trying to do, but in this PR you check the $saveOrder variable for false and allow ordering? That makes no sense $saveOrder has to be true, if it is false the list order is not ordered correctly by the 'ordering' column but if have to!

avatar puneeth2001
puneeth2001 - comment - 2 Mar 2019

Can you say me exactly what to do? I am not able to get the issue correctly.

avatar HLeithner
HLeithner - comment - 2 Mar 2019

@dgrammatiko already explained it:

So in reality the patch should be quite easy: in the filters script we should take care of the form or the table (wherever the nested attribute is set and make sure that the value reflects the filtered list.
Plain English: by default most lists can be nested. If you filter on a category or whatever then probably you loose the nested part but the script still behaves as if the list was still nested...
Should be easy to patch if anyone follows the logic explained above

I didn't looked into it I only checked the PR

avatar infograf768
infograf768 - comment - 2 Mar 2019

this has nothing to do with #24008

avatar puneeth2001 puneeth2001 - change - 2 Mar 2019
Labels Added: ?
avatar HLeithner
HLeithner - comment - 3 Mar 2019

I close this PR because its wrong, please check the original issue again and create a new PR. thx

avatar HLeithner HLeithner - change - 3 Mar 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-03-03 11:06:40
Closed_By HLeithner
avatar HLeithner HLeithner - close - 3 Mar 2019

Add a Comment

Login with GitHub to post a comment