? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
2 Mar 2019

This pr adds the fields checked_out and checked_out_time to the workflow tables.
If this is done, the views of the workflow component can use the checked_out functions as other components.

Testing Instructions

Install a new application and inspect tables: workflows, workflow_stages and workflow_transitions.
Everything should work as before.

NOTE: I could test only the mysql database Would be great if I get help with testing the postgres part.

avatar chmst chmst - open - 2 Mar 2019
avatar chmst chmst - change - 2 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2019
Category SQL Administration com_admin Postgresql Installation
avatar chmst chmst - change - 2 Mar 2019
Title
Prepare Database for checked_out in workflow tables
[4.0] Prepare Database for checked_out in workflow tables
avatar chmst chmst - change - 2 Mar 2019
Title
Prepare Database for checked_out in workflow tables
[4.0] Prepare Database for checked_out in workflow tables
avatar chmst chmst - edited - 2 Mar 2019
avatar chmst chmst - change - 2 Mar 2019
The description was changed
avatar chmst chmst - edited - 2 Mar 2019
avatar amitranjan2
amitranjan2 - comment - 2 Mar 2019


DEFAULT should be numeric 1
Please look at Line 6 also

avatar chmst
chmst - comment - 2 Mar 2019

@amitranjan2 you are right, there are also DEFAULT '0'. But this is not in scope of this PR, it is better you make an extra PR for this.

avatar chmst chmst - change - 2 Mar 2019
Labels Added: ?
avatar amitranjan2
amitranjan2 - comment - 2 Mar 2019

@amitranjan2 you are right, there are also DEFAULT '0'. But this is not in scope of this PR, it is better you make an extra PR for this.

Okay

avatar HLeithner
HLeithner - comment - 2 Mar 2019

@alikon could you test this with pgsql?

avatar drmenzelit
drmenzelit - comment - 7 Apr 2019

I have tested this item successfully on 766ac40

After applying the patch and installing Joomla! 4.0.0-alpha8-dev again I have the new columns checked_out and checked_out_time on the workflow tables.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24059.

avatar drmenzelit drmenzelit - test_item - 7 Apr 2019 - Tested successfully
avatar alikon
alikon - comment - 8 Apr 2019

on pgsql side seem's fine to me

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Apr 2019

@alikon can you please mark your test as successfully?

avatar VladikB VladikB - test_item - 3 Sep 2019 - Tested successfully
avatar VladikB
VladikB - comment - 3 Sep 2019

I have tested this item successfully on 5f8e751

Tested it on mysql


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24059.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Sep 2019

@drmenzelit can you please retest?

avatar drmenzelit drmenzelit - test_item - 3 Sep 2019 - Tested successfully
avatar drmenzelit
drmenzelit - comment - 3 Sep 2019

I have tested this item successfully on 5f8e751


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24059.

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Sep 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Sep 2019

Status "Ready To Commit".

avatar chmst chmst - change - 3 Sep 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 24 Sep 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-24 10:13:20
Closed_By wilsonge
avatar wilsonge wilsonge - close - 24 Sep 2019
avatar wilsonge wilsonge - merge - 24 Sep 2019
avatar wilsonge
wilsonge - comment - 24 Sep 2019

Thankyou!

Add a Comment

Login with GitHub to post a comment