? ? Pending

User tests: Successful: Unsuccessful:

avatar amitranjan2
amitranjan2
2 Mar 2019

Pull Request for Issue # .

Summary of Changes

`INT DEFAULT value changed to numeric from char

Testing Instructions

see the code
installation/sql/mysql/joomla.sql

installation/sql/postgresql/joomla.sql

Expected result

same as before

Actual result

same as before

Documentation Changes Required

NO

4c1b10b 2 Mar 2019 avatar amitranjan2 fix
avatar amitranjan2 amitranjan2 - open - 2 Mar 2019
avatar amitranjan2 amitranjan2 - change - 2 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2019
Category SQL Installation Postgresql
avatar amitranjan2
amitranjan2 - comment - 2 Mar 2019

@alikon some days ago We solved this for joomla [4.0]
remembered?

avatar amitranjan2 amitranjan2 - change - 2 Mar 2019
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 2 Mar 2019

There are more columns remaining that should be changed, e.g.

`language_client_id` tinyint(3) NOT NULL DEFAULT '1',

avatar amitranjan2
amitranjan2 - comment - 2 Mar 2019

There are more columns remaining that should be changed, e.g.

joomla-cms/installation/sql/mysql/joomla.sql

Line 1654 in 5200e18

language_client_id tinyint(3) NOT NULL DEFAULT '1',

done, thanks

48aa889 3 Mar 2019 avatar amitranjan2 fix
avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2019
Category SQL Installation Postgresql SQL Administration com_admin Installation Postgresql
avatar amitranjan2
amitranjan2 - comment - 3 Mar 2019

please take a look at all sql updates files
another example https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/sql/updates/mysql/3.9.0-2018-05-24.sql#L6

Already done
yes, I have checked for mysql as well as PostgreSQL also, thanks
please tell me if any left

avatar alikon alikon - test_item - 3 Mar 2019 - Tested successfully
avatar alikon
alikon - comment - 3 Mar 2019

I have tested this item successfully on 5528cd7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24058.

avatar HLeithner HLeithner - change - 3 Mar 2019
Title
[Staging] Wrong default value [SQL ]
[3.9] Wrong default value [SQL ]
avatar HLeithner HLeithner - edited - 3 Mar 2019
avatar Quy Quy - test_item - 4 Mar 2019 - Tested successfully
avatar Quy
Quy - comment - 4 Mar 2019

I have tested this item successfully on 5528cd7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24058.

avatar Quy Quy - change - 4 Mar 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 4 Mar 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24058.

avatar amitranjan2
amitranjan2 - comment - 7 Mar 2019

@wilsonge if no issues , please kindly merge this

avatar brianteeman
brianteeman - comment - 7 Mar 2019

@amitranjan2 patience is a virtue

avatar HLeithner HLeithner - change - 7 Mar 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-07 20:49:09
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 7 Mar 2019
avatar HLeithner HLeithner - merge - 7 Mar 2019
avatar HLeithner
HLeithner - comment - 7 Mar 2019

thx

avatar amitranjan2
amitranjan2 - comment - 7 Mar 2019

thanks

Add a Comment

Login with GitHub to post a comment