User tests: Successful: Unsuccessful:
The option to email a link to a friend and to print an article were outdated when joomla 1.0 was launched - there are far better ways to share content etc.
This pr removes the show print and email icons options and code to display the icons. (It does not remove the helpers as they haven't been deprecated)
If I understand everything correctly nothing would need to be done to update upgrading sites databases as the stored param would simply be ignored
Resurrection of PR#19393
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_content Language & Strings Front End SQL Installation Postgresql Layout Plugins |
Labels |
Added:
?
?
|
It is not the role of Joomla to translate every possible word or sentence.
Hi,
show_icons and the others 2 still in installation/sql/{mysql|postgres}/sample_testing.sql files
I have tested this item
I have tested this item
I tested this successfully.
I love this change. It is one of the things that I disable first time whenever I set up a new site.
Status | Pending | ⇒ | Ready to Commit |
RTC
updated branch to see if it passes rips
Labels |
Added:
?
|
Sorry missed your mention. :( But it seams rips passes now.
Category | Administration com_content Language & Strings Front End SQL Installation Postgresql Layout Plugins | ⇒ | Administration com_content Front End Installation Layout Plugins Postgresql SQL |
Can you solve the conflicts?
I can but only if it is going to be merged. Otherwise its a waste of my time
Took a look around other websites and all their email options were simply mailto:// links. so i'm happy to remove both (print is clearly outdated in favour of print stylesheets)
print is clearly outdated in favour of print stylesheets
I have clearly demonstrated in #19393 that if it indeed can be done with stylesheets when a unique article is displayed, it is just impossible to get anything usable when the article is displayed in a blog.
Whatever...
Category | Administration com_content Front End SQL Installation Postgresql Layout Plugins | ⇒ | Administration com_content Language & Strings Front End Installation Layout Plugins |
Category | Administration com_content Front End Installation Layout Plugins Language & Strings | ⇒ | Administration com_content Language & Strings Front End SQL Installation Postgresql Layout Plugins |
Hopefully all merge conflicts have now been resolved correctly
I really dont want to have to resolve merge conflicts again :(
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-14 18:49:15 |
Closed_By | ⇒ | roland-d |
Thank you
Thanks
Thank you from me to both @brianteeman and @roland-d
Now when we want to print an article, we have to select and print selected... would be good to have a print feature.
Hi,
what about keeping .ini as is?
Maybe some extension used JGLOBAL_SHOW_EMAIL_ICON_LABEL or JGLOBAL_SHOW_PRINT_ICON_LABEL placeholders, they are pretty generics.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24025.