? ? ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Feb 2019

The option to email a link to a friend and to print an article were outdated when joomla 1.0 was launched - there are far better ways to share content etc.

This pr removes the show print and email icons options and code to display the icons. (It does not remove the helpers as they haven't been deprecated)

If I understand everything correctly nothing would need to be done to update upgrading sites databases as the stored param would simply be ignored

Resurrection of PR#19393

avatar brianteeman brianteeman - open - 26 Feb 2019
avatar brianteeman brianteeman - change - 26 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2019
Category Administration com_content Language & Strings Front End SQL Installation Postgresql Layout Plugins
avatar brianteeman brianteeman - change - 26 Feb 2019
Labels Added: ? ?
avatar ladyjer
ladyjer - comment - 26 Feb 2019

Hi,

what about keeping .ini as is?
Maybe some extension used JGLOBAL_SHOW_EMAIL_ICON_LABEL or JGLOBAL_SHOW_PRINT_ICON_LABEL placeholders, they are pretty generics.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24025.

avatar brianteeman
brianteeman - comment - 26 Feb 2019

It is not the role of Joomla to translate every possible word or sentence.

avatar ladyjer
ladyjer - comment - 26 Feb 2019

Hi,

show_icons and the others 2 still in installation/sql/{mysql|postgres}/sample_testing.sql files


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24025.

avatar brianteeman
brianteeman - comment - 26 Feb 2019

@ladyjer Yes I know - that file is so out of date and not distributed with Joomla that at this time its hardly worth fixing.

avatar ladyjer ladyjer - test_item - 26 Feb 2019 - Tested successfully
avatar ladyjer
ladyjer - comment - 26 Feb 2019

I have tested this item successfully on a1d44e0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24025.

avatar Hackwar Hackwar - test_item - 27 Feb 2019 - Tested successfully
avatar Hackwar
Hackwar - comment - 27 Feb 2019

I have tested this item successfully on a1d44e0

I tested this successfully.

I love this change. It is one of the things that I disable first time whenever I set up a new site.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24025.

avatar Quy Quy - change - 27 Feb 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 27 Feb 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24025.

avatar brianteeman
brianteeman - comment - 28 Feb 2019

@zero-24 please advise on the rips issue

avatar brianteeman
brianteeman - comment - 3 Mar 2019

updated branch to see if it passes rips

avatar brianteeman brianteeman - change - 3 Mar 2019
Labels Added: ?
avatar zero-24
zero-24 - comment - 3 Mar 2019

Sorry missed your mention. :( But it seams rips passes now.

avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2019
Category Administration com_content Language & Strings Front End SQL Installation Postgresql Layout Plugins Administration com_content Front End Installation Layout Plugins Postgresql SQL
avatar Hackwar
Hackwar - comment - 22 Apr 2019

Can you solve the conflicts?

avatar brianteeman
brianteeman - comment - 22 Apr 2019

I can but only if it is going to be merged. Otherwise its a waste of my time

avatar roland-d
roland-d - comment - 19 May 2019

Although I agree with this PR, I will leave the decision to remove this feature to @wilsonge as release lead.

avatar roland-d
roland-d - comment - 5 Jun 2019

Pinging @wilsonge

avatar wilsonge
wilsonge - comment - 7 Jun 2019

Took a look around other websites and all their email options were simply mailto:// links. so i'm happy to remove both (print is clearly outdated in favour of print stylesheets)

avatar infograf768
infograf768 - comment - 8 Jun 2019

print is clearly outdated in favour of print stylesheets

I have clearly demonstrated in #19393 that if it indeed can be done with stylesheets when a unique article is displayed, it is just impossible to get anything usable when the article is displayed in a blog.

Whatever...

avatar joomla-cms-bot joomla-cms-bot - change - 8 Jun 2019
Category Administration com_content Front End SQL Installation Postgresql Layout Plugins Administration com_content Language & Strings Front End Installation Layout Plugins
58bf806 8 Jun 2019 avatar brianteeman sql
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jun 2019
Category Administration com_content Front End Installation Layout Plugins Language & Strings Administration com_content Language & Strings Front End SQL Installation Postgresql Layout Plugins
avatar brianteeman
brianteeman - comment - 8 Jun 2019

Hopefully all merge conflicts have now been resolved correctly

avatar brianteeman
brianteeman - comment - 13 Jun 2019

I really dont want to have to resolve merge conflicts again :(

avatar roland-d roland-d - change - 14 Jun 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-06-14 18:49:15
Closed_By roland-d
avatar roland-d roland-d - close - 14 Jun 2019
avatar roland-d roland-d - merge - 14 Jun 2019
avatar roland-d
roland-d - comment - 14 Jun 2019

Thank you

avatar brianteeman
brianteeman - comment - 14 Jun 2019

Thanks

avatar Hackwar
Hackwar - comment - 14 Jun 2019

Thank you from me to both @brianteeman and @roland-d

avatar pwireless
pwireless - comment - 12 Nov 2021

Now when we want to print an article, we have to select and print selected... would be good to have a print feature.

Add a Comment

Login with GitHub to post a comment