Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24024] - [4.0] validate username

? ? Failure

User tests: Successful: Unsuccessful:

avatar alikon
alikon
26 Feb 2019

Pull Request for Issue #19301 .

Summary of Changes

porting #23918 to 4 branch

Testing Instructions

see #23918

avatar alikon alikon - open - 26 Feb 2019
avatar alikon alikon - change - 26 Feb 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2019
Category ⇒ Installation
avatar ladyjer
ladyjer - comment - 26 Feb 2019

Hi,

test almost successfully, but the INSTL_USERNAME_INVALID placeholder is missing and there is a message talking about wrong db credentials, which actually are correct.

screen shot 2019-02-26 at 21 47 01

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24024.

avatar alikon alikon - change - 27 Feb 2019
Labels Added: ?
avatar alikon
alikon - comment - 27 Feb 2019

@ladyjer that's why is still a Draft one 👅

avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2019
Category Installation ⇒ Installation Language & Strings
avatar alikon alikon - change - 27 Feb 2019
Labels Added: ?
avatar alikon
alikon - comment - 27 Feb 2019

the missing string has been added thanks to @ladyjer

avatar Quy
Quy - comment - 1 Mar 2019

The placeholder %d will be an issue.

avatar alikon
alikon - comment - 1 Mar 2019

placeholder issue fixed

avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2019
Category Installation Language & Strings ⇒ Installation
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Title
…
[4.0][install] - validate username
[4.0] validate username
avatar franz-wohlkoenig franz-wohlkoenig - edited - 19 Apr 2019
avatar joomla-cms-bot joomla-cms-bot - change - 19 Apr 2019
Category Installation ⇒ Installation Language & Strings
avatar alikon alikon - change - 3 Aug 2019
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-08-03 10:10:46
Closed_By ⇒ alikon
Labels Removed: J4 Issue
avatar alikon alikon - close - 3 Aug 2019
avatar HLeithner
HLeithner - comment - 8 Aug 2019

@alikon would you like to bring this PR back?

avatar alikon
alikon - comment - 8 Aug 2019

reopened as requested

avatar alikon alikon - change - 8 Aug 2019
Status Closed ⇒ New
Closed_Date 2019-08-03 10:10:46 ⇒
Closed_By alikon ⇒
avatar alikon alikon - change - 8 Aug 2019
Status New ⇒ Pending
avatar alikon alikon - reopen - 8 Aug 2019
avatar roland-d
roland-d - comment - 31 Aug 2019

@alikon Can you update this PR with the current 4.0-dev branch so I can get this tested? Also move this to a real PR and not a draft? Thanks.

avatar alikon
alikon - comment - 1 Sep 2019

i don't think this is needed anymore due to the merge of 3.9.4 in 4.0

avatar alikon alikon - change - 1 Sep 2019
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-09-01 08:21:53
Closed_By ⇒ alikon
avatar alikon alikon - close - 1 Sep 2019

Add a Comment

Login with GitHub to post a comment