? Success

User tests: Successful: Unsuccessful:

avatar bahl24
bahl24
25 Feb 2019

Pull Request for Issue - Legend styles which existed in J3 are missing, which makes navigation in settings difficult.

Expected result

screenshot from 2019-02-25 16-11-51
screenshot from 2019-02-25 16-10-47

Actual result

screenshot from 2019-02-25 16-18-06

avatar bahl24 bahl24 - open - 25 Feb 2019
avatar bahl24 bahl24 - change - 25 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2019
Category Administration Templates (admin)
avatar bahl24 bahl24 - change - 25 Feb 2019
Labels Added: ?
avatar bahl24
bahl24 - comment - 26 Feb 2019

@infograf768 @C-Lodder What do you think?

avatar Razzo1987 Razzo1987 - test_item - 26 Feb 2019 - Tested unsuccessfully
avatar Razzo1987
Razzo1987 - comment - 26 Feb 2019

I have tested this item ? unsuccessfully on 5d18f97

no change :(


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24012.

avatar wojsmol
wojsmol - comment - 26 Feb 2019

@Razzo1987 You mead to run npm run build:css after applying this patch - see Setting Up Your Local Environment.

avatar bahl24
bahl24 - comment - 26 Feb 2019

The exact command is given in build.js for building scss files.

On Tue 26 Feb, 2019, 2:33 PM Wojciech Smoliński <notifications@github.com
wrote:

@Razzo1987 https://github.com/Razzo1987 You mead to run npm run
build:css after applying this patch - see Setting Up Your Local
Environment
https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#24012 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AibEyg4vwJkKqHLypwN09KIjLuaVnYqTks5vRPhIgaJpZM4bPmSp
.

avatar Razzo1987 Razzo1987 - test_item - 26 Feb 2019 - Tested successfully
avatar Razzo1987
Razzo1987 - comment - 26 Feb 2019

I have tested this item successfully on 5d18f97

Sorry!

with npm run build:css works!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24012.

avatar Quy
Quy - comment - 14 Apr 2019

Related PR #24322

avatar brianteeman
brianteeman - comment - 14 Apr 2019

yes that PR fixes the problem which was a pr that should not have been merged

avatar franz-wohlkoenig franz-wohlkoenig - change - 15 Apr 2019
Title
[4.0]add legend styles in settings
[4.0] add legend styles in settings
avatar franz-wohlkoenig franz-wohlkoenig - edited - 15 Apr 2019
avatar brianteeman
brianteeman - comment - 5 May 2019

This should be closed as it was fixed with #24322

avatar bahl24 bahl24 - change - 5 May 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-05-05 12:35:35
Closed_By bahl24
Labels Removed: J4 Issue
avatar bahl24 bahl24 - close - 5 May 2019

Add a Comment

Login with GitHub to post a comment