[#24011] - [4.0] Removing legacy module chromes
- Fixed in Code Base
- 26 Feb 2019
- Medium
- Build: 4.0-dev
- # 24011
- Diff
- Hackwar:patch-41
User tests: Successful: Unsuccessful:
I would like to clean up some of the module chromes that we have in our codebase. If you look at these 2 chromes, I couldn't think of a reason to keep modChrome_horz. Something like this should be done in CSS and not by throwing yet another table at it.
Likewise with modChrome_rounded. There is border-radius which is a lot better at doing something like this.
Yes, this is a B/C break, but in favour of quality of the resulting websites, I would still do this. Looking forward to your comments.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
Yup agree with @C-Lodder let get rid of the XHTML one too. There's instructions already there on how to migrate to HTML5 one in j3 (https://github.com/joomla/joomla-cms/blob/staging/templates/system/html/modules.php#L85-L88)
what happend to the plan to move module chrome to layouts?
What is the difference between xhtml and html5? On a quick glance, they look identical?
Regarding switching the chromes to layouts as in #23570, I'm not really happy with that PR, but that is mainly related to me not being happy with the layout system in general.
Are we fine with the B/C break? Then I would indeed delete the xhtml chrome, too.
Yup i'm happy. Kill it
Technically there is a difference - the xhtml chrome doesn't have a space between the moduletable class and the suffix whereas html5 does
| Labels |
Added:
?
|
||
done
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-26 12:12:55 |
| Closed_By | ⇒ | wilsonge |
Thanks!
What about
xhtml?