User tests: Successful: Unsuccessful:
According to composer, mso/idna-convert
is abandoned and should be replaced with algo26-matthias/idna-convert
.
Status | New | ⇒ | Pending |
Category | ⇒ | External Library Composer Change |
I think it is the same library.
We can ask author. Will do.
I ran composer update. The former one is deleted while the new one is installed.
The version of the library is the same (1.1.0)
use Mso\IdnaConvert\IdnaConvert;
is used in /libraries/src/String/PunycodeHelper.php
but we also have
"name": "mso/idna-convert",
in
/libraries/vendor/algo26-matthias/idna-convert/composer.json
Also the namespace in the new library is kept
namespace Mso\IdnaConvert;
autoload does a redirect.
READme.md may have to be modified.
Just a test... remaining is for specialists
I confirm though that it works fine. Tested with mail and domain names.
Labels |
Added:
?
?
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-25 21:43:58 |
Closed_By | ⇒ | wilsonge |
Thanks!
it's because:
Please read
algo26-matthias/idna-convert#14 (comment)
Tag has changed
I.e.
"algo26-matthias/idna-convert" : "2.*"
Using this last one I also get changes in composer.lock
Tested new version. I get
Class 'Mso\IdnaConvert\IdnaConvert' not found
version 2.0.2 modified the namespace which is now
namespace Algo26\IdnaConvert;
This implies some changes in our code.
Is this actually b/c with the existing library?