? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
25 Feb 2019

According to composer, mso/idna-convert is abandoned and should be replaced with algo26-matthias/idna-convert.

avatar Hackwar Hackwar - open - 25 Feb 2019
avatar Hackwar Hackwar - change - 25 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2019
Category External Library Composer Change
avatar wilsonge
wilsonge - comment - 25 Feb 2019

Is this actually b/c with the existing library?

avatar infograf768
infograf768 - comment - 25 Feb 2019

I think it is the same library.
We can ask author. Will do.

avatar infograf768
infograf768 - comment - 25 Feb 2019
avatar infograf768
infograf768 - comment - 25 Feb 2019

I ran composer update. The former one is deleted while the new one is installed.

The version of the library is the same (1.1.0)

avatar infograf768
infograf768 - comment - 25 Feb 2019

use Mso\IdnaConvert\IdnaConvert; is used in /libraries/src/String/PunycodeHelper.php
but we also have
"name": "mso/idna-convert",
in
/libraries/vendor/algo26-matthias/idna-convert/composer.json

Also the namespace in the new library is kept
namespace Mso\IdnaConvert;

autoload does a redirect.
READme.md may have to be modified.

Just a test... remaining is for specialists ?

avatar infograf768
infograf768 - comment - 25 Feb 2019

I confirm though that it works fine. Tested with mail and domain names.

avatar wilsonge wilsonge - change - 25 Feb 2019
Labels Added: ? ?
avatar wilsonge wilsonge - change - 25 Feb 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-25 21:43:58
Closed_By wilsonge
avatar wilsonge wilsonge - close - 25 Feb 2019
avatar wilsonge wilsonge - merge - 25 Feb 2019
avatar wilsonge
wilsonge - comment - 25 Feb 2019

Thanks!

avatar glensc
glensc - comment - 26 Feb 2019

#24009 (comment)

it's because:

  1. github redirects old repo to new repo
  2. the new repo is just renamed, so it points to exact same git tag
  3. the immutable git tag still contains the same code
avatar infograf768
infograf768 - comment - 26 Feb 2019

tks, @glensc

avatar infograf768
infograf768 - comment - 26 Feb 2019

Please read
algo26-matthias/idna-convert#14 (comment)

Tag has changed

avatar infograf768
infograf768 - comment - 26 Feb 2019

I.e.
"algo26-matthias/idna-convert" : "2.*"

avatar infograf768
infograf768 - comment - 26 Feb 2019

Using this last one I also get changes in composer.lock

avatar infograf768
infograf768 - comment - 27 Feb 2019

Tested new version. I get
Class 'Mso\IdnaConvert\IdnaConvert' not found

avatar infograf768
infograf768 - comment - 27 Feb 2019

version 2.0.2 modified the namespace which is now
namespace Algo26\IdnaConvert;
This implies some changes in our code.

avatar wilsonge
wilsonge - comment - 27 Feb 2019

#24037 This updates things to latest versions - but yes we should also update to the version 2.0 so there are definitely no conflicts

Add a Comment

Login with GitHub to post a comment