[#24008] - [4.0] Modules drag and drop ordering broken
- Closed
- 24 Nov 2020
- Medium
- Build: master
- # 24008
Steps to reproduce the issue
Make sure you have a number of modules set to the display in the same position.
Filter by this position in the Module Manager.
If a multilingual site, also filter by Language
Drag and drop is totally unreliable although the modules are moved OK in the manager.
The only way to get for example a specific module to display on top on the position is to not NOT FILTER the manager at all and then use drag and drop, or use the Ordering field of the module itself.
| Labels |
Added:
?
|
||
| Labels |
Added:
J4 Issue
|
||
@infograf768 that might be a bug and probably the cause is that the script is reading some attribute to get information if the list has nested elements or not (that's from the top of my head). So in reality the patch should be quite easy: in the filters script we should take care of the form or the table (wherever the nested attribute is set and make sure that the value reflects the filtered list.
Plain English: by default most lists can be nested. If you filter on a category or whatever then probably you loose the nested part but the script still behaves as if the list was still nested...
Should be easy to patch if anyone follows the logic explained above
Should be easy to patch if anyone follows the logic explained above
Just remain to find the "anyone"...
on it.
it is working when we sort it by order, should I make it independent of this thing.
It is not working when filtering.
franz-wohlkoenig
- | Status | New | ⇒ | Discussion |
@infograf768 is it for sure that it is necessary to make drag and drop available for all I mean even without filtering. IMHO it might be done for some reason I think.
it is working for all and also when filtering in 3.x.
People may use few positions and few modules. therefore it is useful for them
| Category | ⇒ | com_modules |
For frontend modules, ordering works fine for me.
For backend modules, ordering is broken both with drag and drop and when trying to set the ordering in the module settings. I only have the option "None" there.
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-28 05:59:23 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_Date | 2019-03-28 05:59:23 | ⇒ | 2019-03-28 05:59:24 |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/24008
| Status | Closed | ⇒ | New |
| Closed_Date | 2019-03-28 05:59:24 | ⇒ | |
| Closed_By | joomla-cms-bot | ⇒ |
My PR solves another issue. While also ordering the drag and drop afaik uses a different JavaScript script (draggable.js).
I am reopening this.
For site modules:
As I said, when filtered, for example by position, the ordering is not respected when it has been done via drag and drop.
Manager
Frontend
It should be:
Switcher
Main Menu
Login form
Editing one of these modules and looking at the Ordering field, we can see it is wrong:
@infograf768 @Bakual Sorry for closing.
| Status | New | ⇒ | Discussion |
jwaisner
- | Status | Discussion | ⇒ | Confirmed |
Still not fixed!
| Title |
|
||||||
| Labels |
Added:
?
|
||
HLeithner
- | Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-24 21:41:06 |
| Closed_By | ⇒ | HLeithner |
wilsonge
- | Labels |
Removed:
?
|
||
@infograf768 Drag and drop is not working in other places also such as article manager