?
avatar brianteeman
brianteeman
21 Feb 2019

Currently the code to link to a tab uses jquery. Not only do we want to get rid of jquery but the code currently doesn't work

Steps to reproduce the issue

Go to Plugins: Content - Page Break and click on "Show full description"

Expected result

go to the description tab

Actual result

Nothing except for this error in the console

joomla-tab.js?9cc7cf41ee2d6c979e5638cff870766e:276 Uncaught TypeError: Cannot read property 'click' of null
    at HTMLElement.showTab (joomla-tab.js?9cc7cf41ee2d6c979e5638cff870766e:276)
    at HTMLElement.connectedCallback (joomla-tab.js?9cc7cf41ee2d6c979e5638cff870766e:159)
    at joomla-tab.js?9cc7cf41ee2d6c979e5638cff870766e:2
    at joomla-tab.js?9cc7cf41ee2d6c979e5638cff870766e:401
avatar brianteeman brianteeman - open - 21 Feb 2019
avatar joomla-cms-bot joomla-cms-bot - change - 21 Feb 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Feb 2019
avatar joomla-cms-bot joomla-cms-bot - edited - 3 Mar 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Mar 2019
Status New Discussion
avatar vijay9908
vijay9908 - comment - 5 Mar 2019

Issue Confirmed
Can I work on this?

avatar vijay9908
vijay9908 - comment - 5 Mar 2019

Can I know what alternative to jquery can be used?

avatar HLeithner
HLeithner - comment - 5 Mar 2019

vanilla es6 JS should be used.

@dgrammatiko may can help here?

avatar vijay9908
vijay9908 - comment - 5 Mar 2019

can someone help me with location of text file from where contents are displayed earlier?

avatar dgrammatiko
dgrammatiko - comment - 5 Mar 2019

@vijay9908 please test #24098

EDIT: my bad, I fixed the wrong issue in that PR

avatar dgrammatiko
dgrammatiko - comment - 5 Mar 2019

@brianteeman just replace the onclick with document.querySelector('#tab-description').click()

avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Mar 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-03-05 15:14:48
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - close - 5 Mar 2019
avatar joomla-cms-bot
joomla-cms-bot - comment - 5 Mar 2019
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Mar 2019

closed as having Pull Request #24098

Add a Comment

Login with GitHub to post a comment