Feeling Lucky
?
?
[#23964] - Article Module comments
- Fixed in Code Base
- 3 Mar 2019
- Medium
- Build: staging
- # 23964
- Diff
- brianteeman:comment_correction
User tests: Successful: Unsuccessful:
If we are going to have comments in code then they should be correct. This PR changes the position of a comment so that it is clear which options it refers to. I wasted hours debugging the code looking for a module param that the comment said should exist and it didnt because the comment was wrong
Pr for #23954
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
Quy
- comment
- 21 Feb 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23964.
viocassel
- comment
- 21 Feb 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23964.
viocassel
- comment
- 21 Feb 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23964.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 21 Feb 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23964.
brianteeman
- comment
- 3 Mar 2019
Is there a reason this is marked for 3.10 and not staging
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-03 22:49:31 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
|
||
HLeithner
- comment
- 3 Mar 2019
Thx
brianteeman
- comment
- 3 Mar 2019
Thanks
I have tested this item✅ successfully on 46df89e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23964.