Feeling Lucky
?
?
[#23938] - [4.0]remove unused method disconnectedCallback
- Closed
- 19 Feb 2019
- Medium
- Build: 4.0-dev
- # 23938
- Diff
- bahl24:fix#23792
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Signed-off-by: Nitish Bahl nitishbahl24@gmail.com
Pull Request for Issue #23792 .
Summary of Changes
Removed unused method disconnectedCallback
Testing Instructions
- Build js files
- Open the browser console
- Go to create a new article in the Joomla backend
- Reduce the browser window width until you see an error in the con
Expected result
No error in console
Actual result
Error in console
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-19 03:43:29 |
| Closed_By | ⇒ | bahl24 |
| Category | JavaScript Repository | ⇒ | JavaScript Repository NPM Change |
| Status | Closed | ⇒ | New |
| Closed_Date | 2019-02-19 03:43:29 | ⇒ | |
| Closed_By | bahl24 | ⇒ | |
| Labels |
Added:
?
|
||
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-19 03:43:53 |
| Closed_By | ⇒ | bahl24 |
Quy
- comment
- 19 Feb 2019
@dgrammatiko Does your PR fix #23792?
dgrammatiko
- comment
- 19 Feb 2019
Yes
@bahl24 please close this pr and head to MDN to read the specs