[#23934] - [4.0] Add support to unpublish module from Control Panel
- Fixed in Code Base
- 20 Mar 2019
- Medium
- Build: 4.0-dev
- # 23934
- Diff
- C-Lodder:cpanel-ajax
User tests: Successful: Unsuccessful:
Summary of Changes
This is a continuation of the initial prototype I did: joomla/40-backend-template#251
In the control panel, we have a cog icon that directs you to the settings for that module. Now, it displays a dropdown with a new option to directly unpublish the module. Upon doing so, it will instantly disappear from the display.
Testing Instructions
- Fetch the code
- Run
npm i(apologies) - Login to the your Joomla admin
- Click the "cog" icon for any module and select "Unpublish" from the dropdown
Note
There are some changes to other files which keeps the dropdowns in other areas of the admin template intact.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_cpanel Language & Strings Modules Templates (admin) JavaScript Repository |
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23934.
Drone throws errors for javascript-cs
| Category | Administration com_cpanel Language & Strings Modules Templates (admin) JavaScript Repository | ⇒ | Administration com_cpanel Language & Strings Modules Templates (admin) JavaScript Repository NPM Change |
Thats a great improvement,
I tested it but the unpublish link does not do anything. The edit link works.
I'd open a seperate issue with following problem:
If you edit the module and close it, you end up in the module manager. It would be good to implement a refererlink on such icons so when you close something you get back to where you came from.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23934.
Thats a great improvement,
I tested it but the unpublish link does not do anything. The edit link works.
I'd open a seperate issue with following problem:
If you edit the module and close it, you end up in the module manager. It would be good to implement a refererlink on such icons so when you close something you get back to where you came from.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23934.
Thanks Elisa. I'll add the refer link.
Shame it doesnt work for you though. Do you get any console errors?
@coolcat-creations are you sure you ran npm i after applying the patch. If you didnt then the dropdown appears but the functionality behind it is not present
| Labels |
Added:
NPM Resource Changed
|
||
If that feature is the correct approach then sure
Regarding the "return"
This issue is common in very many places. eg adding a note to a user
I do think indeed it makes sense to redirect to CPanel when editing the module from there.
Now, tbh, this new feature implies a lot of code for not much gain. But that's only me.
I'll leave it up to your guys then. RTC if you want or I can add the redirect in.
+1 for redirecting to CPanel.
It is not because it does not work elsewhere that we should not do it when we think of it
It is not because it does not work elsewhere that we should not do it when we think of it
Just pointing out that it needs to be done in multiple places not just here
On second thoughts, adding a redirect is out of scope of this PR. This is purely to add support for unpublishing a module via the front-end and does not touch how the edit functionality works.
@coolcat-creations @infograf768 Please create a separate issue
Restarted drone...
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23934.
@brianteeman can you please retest?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23934.
@coolcat-creations
Please test so that we can go on with the return.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23934.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-20 13:58:46 |
| Closed_By | ⇒ | wilsonge |
Thankyou!
@brianteeman All done. Thanks