? Success

User tests: Successful: Unsuccessful:

avatar hardik-codes
hardik-codes
14 Feb 2019

Pull Request for Issue #23795

Summary of Changes

Changed the png clock icon to svg clock icon.
Also the border above Sat and wk is reduced to its normal size

Testing Instructions

1.Open an article in the Joomla backend
2. Open the calendar found under "Start Publishing"

Expected result

23795 1

Actual result

23795 2

Documentation Changes Required

None

avatar hardik-codes hardik-codes - open - 14 Feb 2019
avatar hardik-codes hardik-codes - change - 14 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2019
Category Administration Templates (admin) Repository
avatar hardik-codes hardik-codes - change - 14 Feb 2019
Title
Fix calendar related issues
[4.0] Fix calendar tweaks
avatar hardik-codes hardik-codes - edited - 14 Feb 2019
avatar C-Lodder
C-Lodder - comment - 14 Feb 2019

There is still some sort of misalignment in the top line but everything seems fine for now.

avatar hardik-codes
hardik-codes - comment - 14 Feb 2019

There is still some sort of misalignment in the top line but everything seems fine for now.

Its because of border-collpase: collapse; property but I'm not able to find out in which file it is located

avatar infograf768
infograf768 - comment - 18 Feb 2019

@hardik-codes
I suggest to add in both /build/media_source/system/css/fields/calendar.css and calendar-rtl.css

.calendar-container table {
	border-collapse: separate;
}

that should override the default bootstrap collapse to get

screen shot 2019-02-18 at 16 54 18

Remains to correct the buttons Clear Today Close

avatar hardik-codes hardik-codes - change - 18 Feb 2019
Labels Added: ?
avatar hardik-codes
hardik-codes - comment - 18 Feb 2019

@infograf768
In the comments of the above issue @C-Lodder has mentioned that the buttons will most likely be injected from the JS file and he'll be rewriting the calendar as a custom element soon.

avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2019
Category Administration Templates (admin) Repository Administration Templates (admin) Repository NPM Change
avatar infograf768
infograf768 - comment - 19 Feb 2019

I have tested this item successfully on e92514c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23903.

avatar infograf768
infograf768 - comment - 19 Feb 2019

I have tested this item successfully on e92514c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23903.

avatar infograf768 infograf768 - test_item - 19 Feb 2019 - Tested successfully
avatar wilsonge wilsonge - change - 19 Feb 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-19 14:34:48
Closed_By wilsonge
avatar wilsonge wilsonge - close - 19 Feb 2019
avatar wilsonge wilsonge - merge - 19 Feb 2019

Add a Comment

Login with GitHub to post a comment