User tests: Successful: Unsuccessful:
Pull Request for Issue - When viewing information about an image the text overlaps when toggle menu is open both in PC as well as mobile devices.
Mobile
PC
Removed flex property which solves the issue both in PC and Mobile irrespective of whether toggle menu is open or closed
Mobile-
PC-
Components->media->select an image->info
No
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_media |
all seems fine to me
Category | Administration com_media | ⇒ | Administration com_media NPM Change |
@infograf768 @Quy Kindly test this
(Would need bootstrap override specific to RTL)
In my patch for RTL I have used ul/li and no flex to solve all issues, including in LTR.
Mobile
As you can see, I have also modified css to get more space for the name of the file in mobile vue
I have not proposed this patch yet as it waits for other PRs to be merged, specially
#23950
and
#23756
Ok, I will close it then
On Thu 21 Feb, 2019, 2:04 PM infograf768 <notifications@github.com wrote:
This does not solve RTL.
[image: screen shot 2019-02-21 at 08 59 16]
https://user-images.githubusercontent.com/869724/53152871-0626bc80-35b7-11e9-8ba5-0b9d5f1d4236.png(Would need bootstrap override specific to RTL)
In my patch for RTL I have used ul/li and no flex to solve all issues,
including in LTR.RTL
[image: screen shot 2019-02-21 at 09 18 16]
https://user-images.githubusercontent.com/869724/53153934-cf9e7100-35b9-11e9-9fc4-1853a081015c.pngLTR
[image: screen shot 2019-02-21 at 09 18 48]
https://user-images.githubusercontent.com/869724/53153967-e04ee700-35b9-11e9-8aa4-2b2091f06099.pngMobile
As you can see, I have also modified css to get more space for the name of
the file in mobile vue[image: screen shot 2019-02-21 at 09 25 36]
https://user-images.githubusercontent.com/869724/53154275-b5b15e00-35ba-11e9-87c7-a5c03fadb066.pngI have not proposed this patch yet as it waits for other PRs to be merged,
specially
#23950 #23950
and
#23756 #23756—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#23902 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AibEyszO0DnZsKtlcqUYOAetex0sefOJks5vPln4gaJpZM4a7cT4
.
@infograf768 ol
vs ul
don't need a decision by maintainers. One is an ordered list (1, 2, 3, etc) and the other isn't. In general, using a list would probably be better as there shouldn't be any issues with RTL
In general, using a list would probably be better as the RTL should kick in automatically.
I do prefer ul
in general as they are easier to cope with and we do not need flex at all in this case.
Still needs some tweaks for RTL concerning com_media.
Look here the non-minified css file obtained after my patch. At the bottom of the file are all the RTL overrides, including for infovue.
mediamanager.min.css.zip
Labels |
Added:
NPM Resource Changed
|
OK, I am told that it is better to use <dl>
etc.
Will try to deal with rtl, using your patch.
I have tested this item
OK for LTR. RTL is another story to be dealt with separately. Thanks.
One more tester please.
I have tested this item
OK for LTR. RTL is another story to be dealt with separately. Thanks.
One more tester please.
For me doesn't work :(
@Razzo1987
Have you ran npm ci on the test site?
If not, then the patch is not enough...
Sotty, I didn't.
I understand now I miss this step on my tests. Now I'm redone it
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-26 10:53:46 |
Closed_By | ⇒ | wilsonge |
Merged on JM's request. Thanks!
@infograf768 @dgrammatiko @Quy @C-Lodder Kindly provide feedback regarding the design changes