[#23897] - [4.0] Decode HTML special chars
- Closed
- 3 Jul 2020
- Medium
- Build: 4.0-dev
- # 23897
- Diff
- amitranjan2:decode3
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Decode HTML special chars for diff view.
Testing Instructions
- Create two versions of articles and compare the difference.
- Due to the overlay issue, you need to remove the backdrop by inspecting.
Expected result
Actual result
Documentation Changes Required
NO
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
I don't think using Javascript to decode the entities is the way forward, as there are hundreds of mappings being missed out. Doing this via PHP before the diff is executed might be a better approach
I think jsDiff return the encode HTML special characters. So, how we can achive this in PHP?
Look at how the old and new are displayed. You will need to do something similar with the diff
<?php echo htmlspecialchars($newSubValue, ENT_COMPAT, 'UTF-8'); ?>
Ahh it's jsdiff rendering the string. Can you please try updating to v4.0.0 of the package and see if this works. I'm maintaining one of the developer's projects so I can get in contact with him and see if there's a more viable workaround
| Labels |
Added:
?
|
||
Ahh it's jsdiff rendering the string. Can you please try updating to v4.0.0 of the package and see if this works. I'm maintaining one of the developer's projects so I can get in contact with him and see if there's a more viable workaround
I checked on v4.0.1 . It's not working
franz-wohlkoenig
- | Title |
|
||||||
| Title |
|
||||||
| Category | JavaScript Repository | ⇒ | JavaScript Repository NPM Change |
I compared two versions of the same articles, I observed the problem stated in the issue, but when I applied the patch nothing changed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23897.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23897.
Looks like this can be closed as I cannot replicate the reported issue
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23897.
alikon
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-03 18:51:01 |
| Closed_By | ⇒ | alikon |
I don't think using Javascript to decode the entities is the way forward, as there are hundreds of mappings being missed out. Doing this via PHP before the diff is executed might be a better approach