[#23893] - [4.0] Displays hint alongside action buttons in com_media
- Closed
- 22 Jun 2020
- Medium
- Build: 4.0-dev
- # 23893
- Diff
- bahl24:hintmedia
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
- Pending JTracker/HumanTestResults Human Test Results: 0 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue -It is often confusing to figure out what each media-browser-action button does, this PR adds title to each button which makes media manager easier to use .
Summary of Changes
Added title for preview, select, download etc. buttons
Expected result
Open content -> media to get into images folder and hover above select and action button of any image/directory/video. See hints alongside each action button such as preview, select, download.
Actual result
No hints were displayed earlier
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media |
Sorry but using the title attribute is not accessible. See https://www.mediacurrent.com/blog/dont-rely-title-attribute-accessibility-seo/ for a full explanation.
| Labels |
Added:
?
|
||
I have tested this item
Using the title is not the correct solution.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23893.
I have tested this item unsuccessfully on 7a43941
Using the title is not the correct solution.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23893.
@brianteeman @infograf768 Any other option you have in mind.
@brianteeman This is fine. The elements already have aria-label attribute for users with screen readers. title (which holds the same text as aria-label) is more for users with browsers. Icon alone without any accompanying text is bad UI.
@SharkyKZ aria-label is only useful for people with screen readers. If you are not using a mouse then you cannot see the title. So if you really feel that the icon needs a text explanation then it cannot be done with the title attribute. Accessibility is not just about screenreaders!!
@brianteeman But we use title in many other places on Joomla such as Content->Articles->hover over any existing article to see 'edit' option.
@brianteeman Right. These would have to be Bootstrap/custom tooltips to toggle on focus.
Doesnt mean that it is the right thing to do
On Thu, 14 Feb 2019 at 08:27, SharkyKZ notifications@github.com wrote:
@brianteeman https://github.com/brianteeman Right. These would have to
be Bootstrap/custom tooltips to toggle on focus.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#23893 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8VK18U0xHtoQsZw479IifG8wm0vZks5vNR4HgaJpZM4a5paa
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
These would have to be Bootstrap/custom tooltips to toggle on focus.
Please DO NOT use bootstrap tooltips here
franz-wohlkoenig
- | Title |
|
||||||
| Title |
|
||||||
| Category | Administration com_media | ⇒ | Administration com_media NPM Change |
I have tested this item
No Tooltip text is visible on
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23893.
rajnish-dargan
-
Did you run npm i? if not then you couldnt test
I have tested this item
npm was running but no hints appear (macbook Firefox)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23893.
I can see the hint alongside the button but the edit button disappear on hover so marking unsuccessful.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23893.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23893.
@brianteeman do you have a suggestion as to how this would be better achieve without using Title? For example if we used plan text within the span instead? That would be adequate right?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-22 17:04:03 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
Conflicting Files
?
|
||
Please use language strings.