? ? ? Pending

User tests: Successful: Unsuccessful:

avatar hardik-codes
hardik-codes
13 Feb 2019

Pull Request for Issue #23891

Summary of Changes

Changed the language of toggle editor button from Toggle editor to Toggle Editor

Testing Instructions

Open any article from the article list view.
If there are no articles create one.

Expected result

toggle3

Actual result

toggle 2

Documentation Changes Required

None

avatar hardik-codes hardik-codes - open - 13 Feb 2019
avatar hardik-codes hardik-codes - change - 13 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Feb 2019
Category Administration Language & Strings
avatar infograf768 infograf768 - change - 18 Feb 2019
Labels Added: ? ?
avatar hardik-codes
hardik-codes - comment - 27 Feb 2019

Members please review this PR

avatar infograf768 infograf768 - test_item - 27 Feb 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 27 Feb 2019

I have tested this item successfully on 8074f53

Simple test. Can be merged on review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23892.

avatar HLeithner
HLeithner - comment - 27 Feb 2019

Is there a reason changing this to uppercase? I'm not a native speaker so I wonder.

avatar hardik-codes
hardik-codes - comment - 27 Feb 2019

Is there a reason changing this to uppercase? I'm not a native speaker so I wonder.

Other tabs such as Configure Edit Screen, which comprises of more than one word has its first letter of each word capital, the PR is just to maintain consistency

avatar HLeithner
HLeithner - comment - 27 Feb 2019

@brianteeman perfect thx, I restarted drone without (can't be merged without it)

avatar Quy Quy - test_item - 27 Feb 2019 - Tested successfully
avatar Quy
Quy - comment - 27 Feb 2019

I have tested this item successfully on 8074f53


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23892.

avatar Quy Quy - change - 27 Feb 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 27 Feb 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23892.

avatar HLeithner HLeithner - change - 27 Feb 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 15 Mar 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-15 17:15:24
Closed_By wilsonge
avatar wilsonge wilsonge - close - 15 Mar 2019
avatar wilsonge wilsonge - merge - 15 Mar 2019

Add a Comment

Login with GitHub to post a comment