Feeling Lucky
?
?
[#23880] - [4.0] fix media edit modal cancel button
- Fixed in Code Base
- 13 Feb 2019
- Medium
- Build: 4.0-dev
- # 23880
- Diff
- dgrammatiko:4.0-dev-fix-media-edit-modal
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Labels |
Added:
?
|
||
bahl24
- comment
- 12 Feb 2019
@dgrammatiko On clicking cancel, the whole window closes rather than that operation(like edit in this case). We expect-
Actual- Window closes
Anu1601CS
- comment
- 12 Feb 2019
@bahl24 No, need to confuse. Go here https://issues.joomla.org/
And mark your test.
bahl24
- comment
- 12 Feb 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23880.
bahl24
- comment
- 12 Feb 2019
@bahl24 No, need to confuse. Go here https://issues.joomla.org/
And mark your test.
@Anu1601CS Thanks for your help.
infograf768
- comment
- 13 Feb 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23880.
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 13 Feb 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23880.
laoneo
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-13 07:21:37 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
dgrammatiko
- comment
- 13 Feb 2019
Thanks
I have tested this item✅ successfully on 3d0d079
After modifying /build/media_source/com_media/js/edit-images.es6.js
and running
npm run build:js
looks like it works, ie it closes the modal and falls back to the content tab.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23880.