Feeling Lucky
?
?
[#23870] - [4.0][a11y] Missing ID attribute in the input field on the Smart Search module
- Fixed in Code Base
- 27 Feb 2019
- Medium
- Build: 4.0-dev
- # 23870
- Diff
- wojsmol:40-a11y-mod_finder-id
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23861.
Summary of Changes
Added missing id to label in mod_finder
Testing Instructions
code review
Expected result
The input field should have an ID attribute so that browsers and assistive technologies recognize the label for this field.
Actual result
There is a "Search" label for the input field in the Smart Search module. The label can only be visible for screen readers. Unfortunately, the attribute for the label refers to an ID that does not exist because the input field does not have an ID attribute.
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Title |
|
||||||
Quy
- comment
- 11 Feb 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23870.
Quy
- comment
- 11 Feb 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23870.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 11 Feb 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23870.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-27 13:50:46 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 27 Feb 2019
Thanks!
I have tested this item✅ successfully on b30f56c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23870.