Feeling Lucky
?
[#23869] - Propose changes for more descriptive pull requests
- Closed
- 10 Feb 2019
- Medium
- Build: staging
- # 23869
- Diff
- PhilETaylor:patch-51
User tests: Successful: Unsuccessful:
Propose changes for more descriptive pull requests, because, well, why not.
To encourage better pull request text so that maintainers have more information on which to make quicker merge decisions without having to go to a million pages to locate the information they need.
To encourage developers to think more about Licensing Compliance and Security.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-10 20:37:22 |
| Closed_By | ⇒ | PhilETaylor |
Summary Of The Issue This PR Addresses
Issue #1
The problem is that this !== that when 2 and 3 are used.
Summary Of Changes In This PR
This pr changes the input so that 2 and 2 are used, meaning that === this
How Has This Been Tested?
(Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.)
I have included 16 unit tests that cover all of the changes that this PR makes, you can run them before the PR is applied and see that they fail, and you can see after the PR is applied that they all pass.
To see that this === that in the admin console, click this and see that that is the same.
Before Applying This PR The Experienced Result Is
this !== that in the admin console when clicking this.
After Applying This PR The Expected Result Is
this === that in the admin console when clicking this.
Documentation Changes Required
I ahve already updated the documentation on the wiki - here is the link (just kidding!)
Links To Any Reference Material/Posts/Notes
Compliance & Legal
(Check if this change requires any compliance with upstream license/trademark)
The changes are made in files that the Joomla project already has copyright of. No upstream compliance is needed.
Could This PR Have An Impact On Security
(E.g if it changes input filtering/or ACL)
yes, because this no longer equals that, we might want the @ j o o m l a / security team to review this change