Joomla! Issue Tracker | Joomla! CMS #23854 - [4.0] Make readonly-mode for codemirror editable

Closed
8 Jul 2019
Medium
Build: 4.0-dev
# 23854
Diff
astridx:codemirror_readonlymode_template_diffview

Success

Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
Success continuous-integration/drone/pr the build was successful Details

User tests: Successful: Unsuccessful:

astridx
10 Feb 2019

Pull Request for Issue #23775

Summary of Changes

Up to we set the readonly mode for the editor codemirror fix to nocursor

joomla-cms/plugins/editors/codemirror/codemirror.php

Line 131 in ad2c673

$options->readOnly = 'nocursor';

Codemirror offers the readonly mode true where focusing is allowed: https://codemirror.net/doc/manual.html. In the mode true you can copy and past text.

I added the possibility to set a special mode for readonly.

Testing Instructions

Open the view templates in template manager administrator/index.php?option=com_templates&view=templates
Open the template cassiopeia.
Open the tab Create Overrides
Click on com_content and then on article to create an override for com_content view article
Open the tab Editor and open the just created override. For this you have to click on the left folder-tree on com_content, then on article and after that on default.php. Check if the switcher show original is active. See attached picture.
See that it is not possible to copy text from the original file in the editor with readonly mode to the clipboard.
Apply this patch and check again. Now it is possible to copy text to the clipboard.