? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
10 Feb 2019

Pull Request for Issue #23841

Summary of Changes

now the plugin link open the plugin edit

Testing Instructions

see #23841

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar alikon alikon - open - 10 Feb 2019
avatar alikon alikon - change - 10 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2019
Category Administration
avatar alikon alikon - change - 10 Feb 2019
Labels Added: ?
avatar tecpromotion
tecpromotion - comment - 10 Feb 2019

I have tested this item successfully on 00a464f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23853.

avatar tecpromotion tecpromotion - test_item - 10 Feb 2019 - Tested successfully
avatar viocassel
viocassel - comment - 10 Feb 2019

I have tested this item successfully on 00a464f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23853.

avatar viocassel viocassel - test_item - 10 Feb 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Feb 2019

Thanks @alikon

avatar joomdonation
joomdonation - comment - 10 Feb 2019

Sorry but this does not look like a right fix to me. We should not introduce component specific logic into that method. There are better ways to fix this:

  1. The most safe method is adding new language items for this specific plugin content type, 4 new language items needed (we use similar method for plugin installed/uninstalled already https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.plg_actionlog_joomla.ini#L53. Something like:
PLG_ACTIONLOG_JOOMLA_PLUGIN_PUBLISHED="User <a href='{accountlink}'>{username}</a> published the plugin <a href='index.php?option=com_plugins&task=plugin.edit&extension_id={id}'>{title}</a>"
PLG_ACTIONLOG_JOOMLA_PLUGIN_UNPUBLISHED="User <a href='{accountlink}'>{username}</a> umpublished the plugin <a href='index.php?option=com_plugins&task=plugin.edit&extension_id={id}'>{title}</a>"
PLG_ACTIONLOG_JOOMLA_PLUGIN_ARCHIVED="User <a href='{accountlink}'>{username}</a> ARCHIVED the plugin <a href='index.php?option=com_plugins&task=plugin.edit&extension_id={id}'>{title}</a>"
PLG_ACTIONLOG_JOOMLA_PLUGIN_TRASHED="User <a href='{accountlink}'>{username}</a> trashed the plugin <a href='index.php?option=com_plugins&task=plugin.edit&extension_id={id}'>{title}</a>"
  1. If we cannot introduce new language items now because we are in RC state, then you can add getContentTypeLink method to PluginsHelper class https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_plugins/helpers/plugins.php to return the link in expected format
avatar brianteeman
brianteeman - comment - 10 Feb 2019

I have tested this item successfully on 00a464f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23853.

avatar brianteeman brianteeman - test_item - 10 Feb 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 10 Feb 2019

See #23857 for alternative please.

avatar HLeithner
HLeithner - comment - 10 Feb 2019

#23857 seams to be the correct way to do it, please test it so I can merge it before release get packaged tomorrow.

avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2019
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 11 Feb 2019
avatar Quy Quy - change - 11 Feb 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-02-11 12:53:28
Closed_By Quy
avatar joomla-cms-bot
joomla-cms-bot - comment - 11 Feb 2019

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23853

Add a Comment

Login with GitHub to post a comment