Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23767] - [4.0] Toolbar custom element improvements

NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
4 Feb 2019

Summary of Changes

  • Throw an error if the Joomla API hasn't been initiated
  • Add disconnectedCallback method
  • Use template literals
  • eslint fixes

Testing Instructions

  1. Go to create a new article
  2. Ensure the category selection dropdown still works as expected
avatar C-Lodder C-Lodder - open - 4 Feb 2019
avatar C-Lodder C-Lodder - change - 4 Feb 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Feb 2019
Category ⇒ JavaScript Repository
avatar C-Lodder C-Lodder - change - 4 Feb 2019
The description was changed
avatar C-Lodder C-Lodder - edited - 4 Feb 2019
avatar C-Lodder C-Lodder - change - 4 Feb 2019
Labels Added: ?
901230b 8 Feb 2019 avatar C-Lodder jscs
47dd483 8 Feb 2019 avatar C-Lodder jscs
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2019
Category JavaScript Repository ⇒ JavaScript Repository NPM Change
avatar C-Lodder
C-Lodder - comment - 19 Feb 2019

@dgrammatiko @Fedik changes done

avatar C-Lodder C-Lodder - change - 19 Feb 2019
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 27 Feb 2019

@wilsonge this is ready

avatar C-Lodder C-Lodder - change - 27 Feb 2019
Labels Added: NPM Resource Changed
Removed: ?
avatar wilsonge wilsonge - change - 7 Mar 2019
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-03-07 21:19:26
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 7 Mar 2019
avatar wilsonge wilsonge - merge - 7 Mar 2019
avatar wilsonge
wilsonge - comment - 7 Mar 2019

Thanks!

Add a Comment

Login with GitHub to post a comment