Nice!

Can I ask for one more PR: update to the latest version of the deps (vue, etc) and also devDependencies (Webpack, etc)?

Nice!

Can I ask for one more PR: update to the latest version of the deps (vue, etc) and also
devDependencies (Webpack, etc)?

Thanks
All done.

Works fine. ?

As I guess we can't use Plural form in our js, I suggest to change the string
from
COM_MEDIA_CONFIRM_DELETE_MODEL_DESC="Are you sure you want to delete this item?"
to rather use JGLOBAL_CONFIRM_DELETE as the string is quite neuter.

JGLOBAL_CONFIRM_DELETE="Are you sure you want to delete? Confirming will permanently delete the selected item(s)!"

which is the global alert in core.

@infograf768

As I guess we can't use Plural form in our js, I suggest to change the string
from
COM_MEDIA_CONFIRM_DELETE_MODEL_DESC="Are you sure you want to delete this item?"
to rather use JGLOBAL_CONFIRM_DELETE as the string is quite neuter.

JGLOBAL_CONFIRM_DELETE="Are you sure you want to delete? Confirming will permanently delete the selected item(s)!"
which is the global alert in core.

I think for this another PR is fine :)

npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.

Something didn't work while changing the package.json

weird. It worked yesterday. I get that error today

Now I think it should be fine.

@dgrammatiko I have updated root package.json. Should I leave the changes or revert this one?

@rdeutz @dgrammatiko Now I think this is expected the behavior of system-testing because now Instead of direct delete program need to click the alert button to confirm.

npm ci now works.

I think for this another PR is fine :)

OK, will also modify MODEL to MODAL for confirm delete as this is obviously a typo.
Typo also for COM_MEDIA_ACTIN_RENAME="Rename item" as it should be ACTION

Also strings like COM_MEDIA_MEDIA_CREATED_AT="Created at" don't look nice.
It should be imho COM_MEDIA_MEDIA_CREATED="Date created"

ALSO as a note:
For the infobar.vue we have issues in the display as the <dl><dt><dd> will not only not fit quite a few languages (we should have at least the "label" and "value" on 2 different lines i.e. we may have to use <ul><li> instead, but also breaks when reducing window size in whatever language and as well when using RTL languages)

Many other aspects of the manager (tree, etc.) have to be dealt with in RTL
The date created and modified are not translated in Persian, in infobar.vue as well as in browser.vue.

I can solve some of these: the strings and some of the RTL, but not sure about the date format for Persian.

Just have to remember to make a patch for all these after this PR is merged.

@Anu1601CS please revert the changes in the root package.json, I was only referring to the package.json for the media manager

Restarted drone

@rdeutz @laoneo Need to update the system testing.

@Anu1601CS
Please update sytem tests as they are broken.

Please update sytem tests as they are broken.

@infograf768
Ok, I will try to update system testing.

Is this system testing repo https://github.com/joomla/test-system

Is this system testing repo https://github.com/joomla/test-system

Yep, for now. But we have a PR to move these back to main repo.
See #23962

Can you add a id on line 10 of confirm-delete-modal.vue please? So it's <button class="btn btn-danger" id="confirm_delete_item" @click="deleteItem()">{{ translate('COM_MEDIA_CONFIRM_DELETE_MODEL') }}</button>

So that it is selectable in the system tests please

@wilsonge Done

I think joomla/test-system#53 should solve the tests here

I think joomla/test-system#53 should solve the tests here

@wilsonge

I think yes. Instead of direct delete, we need to click modal confirm button.

@rdeutz can i have some help here please. I merged the system tests fix - but the composer update doesn't seem to be making a difference here. Is that related to cache'ing or am i doing something stupid?

@wilsonge use [NO CACHE] in the title, eg
[4.0][NO CACHE] Fix Media Manager delete alert not used.

Done. It did skip the restore-cache step - but still not getting the updated test

OK Packagist hasn't actually updated with the hash of the new commit :( i don't know if there's even a good way to trigger that https://packagist.org/packages/joomla/test-system#dev-4.0-dev

Well, that's the docs for the caching but I guess the problem is in the composer.

Can you change

@rdeutz there's no webhook to packagist configured for the system test repo - i don't own the packagist repo so you need to fix that i'm afraid

[NO CACHE] must be part of the commit message

webhooks are all fine

@SniperSister @zero-24 can you have a look at RIPS here please

Thanks!

Please test #24258