Feeling Lucky
?
[#23742] - [4.0] Do NOT force jQuery.js and Bootstrap.js in the backend template
- Fixed in Code Base
- 22 Feb 2019
- Medium
- Build: 4.0-dev
- # 23742
- Diff
- dgrammatiko:4.0-dev-atum
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Removed the dictated jQuery.js and Bootstrap.js from the backend template.
- Reason: almost ALL interactive components for Bootstrap are held by a PHP helper (
HTMLHelper::_('bootstrap.something'...)) therefor there is zero benefit forcing these scripts in the index.php of the template. Also we've (as the Javascript team) put a huge amount of work to convert everything to vanilla javascript and quite frankly by forcing jQuery always makes all that work redundant.
Testing Instructions
Check that all pages in the backend still work
Expected result
No change
Actual result
Documentation Changes Required
No. jQuery and Bootstrap.js are still supported and can be loaded whenever they're needed but they're not forced anymore
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_cpanel com_media Modules Templates (admin) |
| Labels |
Added:
?
|
||
| Category | Administration com_cpanel com_media Modules Templates (admin) | ⇒ | Administration com_cpanel Modules Templates (admin) |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-22 15:14:07 |
| Closed_By | ⇒ | wilsonge |
Fedik
- comment
- 8 Jan 2020
what changes? :)
anything can be, there was many changes
dgrammatiko
- comment
- 8 Jan 2020
You switched back to forcing BS js on the index.php
Fedik
- comment
- 8 Jan 2020
you mean changes in joomla.asset.json?
well, I did not forcing anything 
there was 1000 merge conflicts in that file, that can accidentally mix the changes
dgrammatiko
- comment
- 8 Jan 2020
I know, but basically you reverted this PR
Just for the record IF we move to BS5 before stable (and therefore don't have to load jquery) I might reconsider this and revert back to loading bs5.js with the BACKEND template (not the frontend if/when we sort that out)