[#23741] - [staging] Follow up on #23604 Custom modules editor field
- Fixed in Code Base
- 25 Feb 2019
- Medium
- Build: staging
- # 23741
- Diff
- infograf768:hascontent
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23604 (comment)
Summary of Changes
After that discussion and merge of #23604 @HLeithner and I thought that we may have the wrong code since 1.5 (see discussion above) concerning the way to get an editor field in Custom modules or similar using < customContent /> in their manifest.
This patch also simplifies the custom type module edit in frontend as we now check the xml, thus normalizing the code vs backend.
Testing Instructions
Install mod_customadv.zip
Create or edit a custom module and the module above in back-end and frontend to confirm the editor field displays.
Pinging also @johanjanssens (see discussion) as the original code comes from 1.5 and, before merging this, it would be important to know if there was a reason for it or if it was just a typo that made gently its way until now...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules Front End com_config |
| Title |
|
||||||
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23741.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23741.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23741.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23741.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23741.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-25 17:10:49 |
| Closed_By | ⇒ | HLeithner |
thx
@HLeithner
done