? Success

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
1 Feb 2019

Seems like this file is a leftover of earlier cleanup.

avatar Hackwar Hackwar - open - 1 Feb 2019
avatar Hackwar Hackwar - change - 1 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Feb 2019
Category JavaScript Administration Templates (admin)
avatar dgrammatiko
dgrammatiko - comment - 2 Feb 2019

You're breaking B/C here.
That code ensures that group buttons will work as they meant to...

In order to remove this part you need first this: #20549

avatar HLeithner
HLeithner - comment - 2 Feb 2019

Seams that got fixed in 6a3edd0 ? because in this commit the original template.js as been deleted.

avatar dgrammatiko
dgrammatiko - comment - 2 Feb 2019

@HLeithner No, that PR assumes that bootstrap.js is always loaded by the template. This won't be the case for Atum...

avatar wilsonge
wilsonge - comment - 2 Feb 2019

@dgrammatiko why is there only a minified file committed then? There is no way of trying to get the original back out from this i guess

avatar Hackwar
Hackwar - comment - 2 Feb 2019

There is no original source of that JS file anymore and the code has not been included in the template for pretty exactly a year now: #19326

avatar Hackwar
Hackwar - comment - 2 Feb 2019

@wilsonge we can of course restore the old file from a year ago, but considering that it has not been included for a year and nobody really noticed it, I would claim that it is not needed.

avatar HLeithner
HLeithner - comment - 2 Feb 2019

@HLeithner No, that PR assumes that bootstrap.js is always loaded by the template. This won't be the case for Atum...

You reopend #20549 do you try to fix the Situation suiteable for screenreaders?

avatar dgrammatiko
dgrammatiko - comment - 2 Feb 2019

@Hackwar @wilsonge go ahead and remove it. I already reopened #20549 and will patch the a11y concerns there.

FWIW my point was that @Bakual 's PR removing the js file was based on the assumption that Bootstrap.js will always be loaded, which of course is wrong as both Atum and Cassiopeia will be free from jQuery.js and Bootstrap.js

avatar Bakual
Bakual - comment - 2 Feb 2019

This PR indeed is fine since my PR back then removed all reference to load that file. I don't know why I missed the minified one. The code in that file was broken anyway.

FWIW my point was that @Bakual 's PR removing the js file was based on the assumption that Bootstrap.js will always be loaded, which of course is wrong as both Atum and Cassiopeia will be free from jQuery.js and Bootstrap.js

That's true, and explicitely mentioned in my PR back then:

Since Bootstrap is loaded anyway and it offers the same functionality, we can use just that one for now (until it gets eventually converted to a CE).

So yes, it's one roadblock to get Bootstrap removed from the template.

avatar wilsonge wilsonge - change - 27 Feb 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-27 16:50:17
Closed_By wilsonge
avatar wilsonge wilsonge - close - 27 Feb 2019
avatar wilsonge wilsonge - merge - 27 Feb 2019
avatar wilsonge
wilsonge - comment - 27 Feb 2019

Thanks!

Add a Comment

Login with GitHub to post a comment