Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23726] - [4.0] Correcting success colour after installing sample data

? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
31 Jan 2019

Pull Request for Issue #23632

Summary of Changes

When using Joomla.renderMessages, the correct class for a success and getting a greenish colour is message and not success.
This is defined in core.es6.js by the code

if (['notice', 'message', 'error', 'warning'].indexOf(type) > -1) {
          alertClass = (type === 'notice') ? 'info' : type;
          alertClass = (type === 'message') ? 'success' : alertClass;
          alertClass = (type === 'error') ? 'danger' : alertClass;
          alertClass = (type === 'warning') ? 'warning' : alertClass;
        } else {
          alertClass = 'info';
        }

Testing Instructions

Patch.
Run npm ci
Install some sample data

After patch

screen shot 2019-01-31 at 11 20 06

avatar infograf768 infograf768 - open - 31 Jan 2019
avatar infograf768 infograf768 - change - 31 Jan 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2019
Category ⇒ JavaScript Repository
avatar infograf768
infograf768 - comment - 31 Jan 2019

@zero-24
RIPS please

avatar zero-24
zero-24 - comment - 31 Jan 2019

Rips is happy here now

avatar PhilETaylor
PhilETaylor - comment - 31 Jan 2019

@infograf768 I think you should be the CODEOWNER for alert messages after all your work on them :)

avatar Quy
Quy - comment - 31 Jan 2019

I have tested this item ✅ successfully on bdbb6b0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23726.

avatar Quy Quy - test_item - 31 Jan 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 31 Jan 2019

@PhilETaylor
no thanks for owning code.?
but your test would help to get that in...

avatar infograf768 infograf768 - change - 31 Jan 2019
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 31 Jan 2019

My home iMac has (yet another) hardware issue... Im struggling to even get my life together this week... should be more productive over the weekend.

avatar infograf768
infograf768 - comment - 1 Feb 2019

@C-Lodder

avatar bonzani
bonzani - comment - 1 Feb 2019

I have tested this item ✅ successfully on 497337e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23726.

avatar bonzani bonzani - test_item - 1 Feb 2019 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 1 Feb 2019

It's weird that this PR actually solves the issue but either way. +1 from me if that's the final result

avatar Quy Quy - alter_testresult - 1 Feb 2019 - Quy: Tested successfully
avatar Quy Quy - change - 1 Feb 2019
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 1 Feb 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23726.

avatar Quy
Quy - comment - 1 Feb 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23726.

avatar wilsonge wilsonge - change - 2 Feb 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 2 Feb 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-02-02 15:45:23
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 2 Feb 2019
avatar wilsonge wilsonge - merge - 2 Feb 2019
avatar wilsonge
wilsonge - comment - 2 Feb 2019

Thanks JM!

Add a Comment

Login with GitHub to post a comment