? ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
30 Jan 2019

If a content language is trashed but not deleted, it appears as Published in the Multilingual status Module.
Thanks Mig for finding this bug.

Summary of Changes

Separating the statuses to include the trashed possibility.
Display a trash icon when a Content Language is trashed.
Also display a specific message on top of the module in that case.

Testing Instructions

Install a multilingual site from a clean Joomla.
Use multiple content languages.
Trash one of the content languages.
Display the module.

fa-IR is trashed below

Before patch

screen shot 2019-01-30 at 16 38 07

After patch

screen shot 2019-01-30 at 16 37 02

avatar infograf768 infograf768 - open - 30 Jan 2019
avatar infograf768 infograf768 - change - 30 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2019
Category Administration com_languages Language & Strings
avatar imanickam
imanickam - comment - 30 Jan 2019

I have tested this item successfully on 7a1d26f

I have tested this successfully on Joomla! 3.9.2.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23722.

avatar imanickam imanickam - test_item - 30 Jan 2019 - Tested successfully
avatar alikon
alikon - comment - 30 Jan 2019

I have tested this item successfully on 7a1d26f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23722.

avatar alikon
alikon - comment - 30 Jan 2019

I have tested this item successfully on 7a1d26f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23722.

avatar alikon alikon - test_item - 30 Jan 2019 - Tested successfully
avatar Quy Quy - change - 30 Jan 2019
The description was changed
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 30 Jan 2019
avatar joomla-cms-bot joomla-cms-bot - edited - 30 Jan 2019
avatar Quy
Quy - comment - 30 Jan 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23722.

avatar Quy
Quy - comment - 30 Jan 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23722.

avatar infograf768 infograf768 - change - 31 Jan 2019
Labels Added: ? ? ?
avatar HLeithner
HLeithner - comment - 31 Jan 2019

In Line 216/230 we have 2 closing could you remove one of them.

avatar infograf768
infograf768 - comment - 1 Feb 2019

Thanks @Quy
Indeed I should have tested before changing to ===
</tr> also corrected (that was an old one)

avatar infograf768 infograf768 - alter_testresult - 1 Feb 2019 - alikon: Tested successfully
avatar infograf768 infograf768 - alter_testresult - 1 Feb 2019 - imanickam: Tested successfully
avatar infograf768
infograf768 - comment - 1 Feb 2019

@imanickam @alikon
Please test again. Same instructions. Policy wants it.

avatar HLeithner HLeithner - change - 1 Feb 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-01 16:00:16
Closed_By HLeithner
avatar HLeithner HLeithner - close - 1 Feb 2019
avatar HLeithner HLeithner - merge - 1 Feb 2019
avatar HLeithner
HLeithner - comment - 1 Feb 2019

thx

Add a Comment

Login with GitHub to post a comment