Please use language strings and not static text.

ok, ill change it

On Wed, 30 Jan 2019, 20:47 Quy <notifications@github.com wrote:

Please use language strings and not static text.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#23721 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ApyKVErw5DJUn7GS8g49X0IjqxiQ4m5aks5vIbeXgaJpZM4aaRD7
.

Hmm. I tested some stuff by just using another string instead of JAPPLY and I see no change...
Looks like any new string has to be added to
/administrator/components/com_media/tmpl/media/default_texts.php

I used therefore
<button class="btn btn-success" @click="save()" :disabled="!isValid()">{{ translate('JACTION_CREATE') }}
but no success.

It looks that any change done in these .vue is NOT taken care of.

yes modifying this is not enough there are 3 to 4 files associated with
this.

On Sat, 2 Feb 2019, 15:07 infograf768 <notifications@github.com wrote:

It looks that any change done in these .vue is NOT taken care of.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#23721 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ApyKVCD6TKthsd7ocl7ttjOWzDJGN8o0ks5vJVxhgaJpZM4aaRD7
.

In fact it works. One has to run npm ci after the changes in both files.
I just did it only for the create button.

So, for the text, it's OK. Can be done easily.
For the size, one should modify'sm' to 'md'
In that case, the width is adapted to the length of the text.
Here for French

ohk I will check it, and post it as soon as possible

I have added the default_text.php to this PR since I had some problem with branches #23745

should I remove the placeholder!

Yes, see my code above.

@zwiastunsw
How to fit accesibility here?

There are many problems here....

1. The text field must have a label. Label must remain.
2. The content of the label should rather be the Folder name
3. The placeholder is redundant.

In addition:
5. Modal window has an unnecessary attribute role="document". Rather it should be: role="alertdialog"
6. The Close, Cancel, Save buttons cannot be operated via the keyboard.

@zwiastunsw

1. Ok to keep the Label with a string which value would be “Folder name”
   New string to create.
   COM_MEDIA_FOLDER_NAME="Folder Name"

2. concerning role, no idea. You know better

concerning close, cancel, save this is not the only place in com_media where the issue is present.
these .vue are not easy to deal with. I am not familar with their code.

There are many problems here....

1. The text field must have a label. Label must remain.
2. The content of the label should rather be the Folder name
3. The placeholder is redundant.

In addition:
5. Modal window has an unnecessary attribute role="document". Rather it should be: role="alertdialog"
6. The Close, Cancel, Save buttons cannot be operated via the keyboard.

noted!

@zwiastunsw
should role be changed in administrator/components/com_media/resources/scripts/components/modals/modal.vue

can I know if my PR is reviewed or not.

Just spent an hour trying to test this PR where changes in a vue.js scripts are made.
npm don several times - but nothing changes.

I do not understand why we have such a mess with removing the dependecy from jQuery in V4.0 and replace it with dependecy from vue.js?

I have tested this item ✅ successfully on f22b205

@Quy can you review this, please.

Can you fix the file permissions here (you've accidentally changed the file create-folder-modal.vue from 644 to 755)

I have tested this item ✅ successfully on 8585b98

I tested succesfully only: "The placeholder and the save button are changed accordingly"
Keyboard still not supported

#24018 I did all those changes here sice there is a problem with this branch