Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23713] - [4.0] WebAssetManager: Speed up enable/disable asset

? Failure

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
29 Jan 2019

Summary of Changes

WebAssetManager calculate dependencies on "request" (when it really need) instead of each call of enableAsset/disableAsset.
This will speed up operations like:

$wa->enableAsset('foo')
  ->enableAsset('bar')
  ->disableAsset('bear')
  ->enableAsset('beer');

Additionally I have updated a comment for a Manager interface, added missed throws tags.

Testing Instructions

Apply the patch and make sure everything still work ?

ping @wilsonge

for reference #22435

avatar Fedik Fedik - open - 29 Jan 2019
avatar Fedik Fedik - change - 29 Jan 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jan 2019
Category ⇒ Libraries
avatar Fedik
Fedik - comment - 29 Jan 2019

I think I am banned to see ci.joomla.org, so cannot help with Drone, sorry ?

avatar dgrammatiko
dgrammatiko - comment - 29 Jan 2019

@Fedik here is the failure:

FILE: ...github.com/joomla/joomla-cms/libraries/src/WebAsset/WebAssetManager.php
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
 91 | ERROR | Expected 1 blank line before member var; 2 found
avatar Fedik
Fedik - comment - 29 Jan 2019

@dgrammatiko thanks!

c96b20d 29 Jan 2019 avatar Fedik phpcs
avatar Fedik Fedik - change - 29 Jan 2019
Labels Added: ?
avatar Fedik Fedik - change - 2 Feb 2019
The description was changed
avatar Fedik Fedik - edited - 2 Feb 2019
avatar Fedik Fedik - change - 5 May 2019
Labels Removed: J4 Issue
avatar wilsonge wilsonge - close - 5 May 2019
avatar wilsonge wilsonge - merge - 5 May 2019
avatar wilsonge wilsonge - change - 5 May 2019
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-05-05 20:52:44
Closed_By ⇒ wilsonge
avatar wilsonge
wilsonge - comment - 5 May 2019

Thanks!

Add a Comment

Login with GitHub to post a comment