? ? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
29 Jan 2019

Pull Request for Issue #23702

Summary of Changes

  • Additional check if filename contains a hyphen. Only then it's guaranteed that $size = count($explodeArray); (line 568) has a minimal value 2 and $explodeArray[$size - 2] (line 569) will not throw a waning.

Testing Instructions

  • Code review after reading #23702 (comment)

  • Or build your custom update/full package with this pr applied and follow instructions in #23702 (comment)

  • Test with "Joomla Patch Tester"? NO. Not possible.

avatar ReLater ReLater - open - 29 Jan 2019
avatar ReLater ReLater - change - 29 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jan 2019
Category Administration com_templates
avatar ReLater ReLater - change - 29 Jan 2019
The description was changed
avatar ReLater ReLater - edited - 29 Jan 2019
avatar astridx
astridx - comment - 9 Feb 2019

I have tested this PR. But I did it a different way:
I saw this error message in template manager after renaming an override file form default.php to default9.php. And after that I saw this error every time I clicked on the filename for opening the file default9.php in the template manager.

After applying this patch everything works fine. If this type of test is also OK, then Patch Tester could be used.

templates customise cassiopeia rsfd administration
templates customise cassiopeia rsfd administration 1

avatar astridx
astridx - comment - 9 Feb 2019

I have tested this item successfully on 35cc995


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23712.

avatar astridx astridx - test_item - 9 Feb 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 19 Apr 2019

I have tested this item successfully on 35cc995


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23712.

avatar SharkyKZ SharkyKZ - test_item - 19 Apr 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Apr 2019

Status "Ready To Commit".

avatar zero-24 zero-24 - change - 19 Apr 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 22 Apr 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-22 22:31:08
Closed_By wilsonge
Labels Removed: J4 Issue
avatar wilsonge wilsonge - close - 22 Apr 2019
avatar wilsonge wilsonge - merge - 22 Apr 2019
avatar wilsonge
wilsonge - comment - 22 Apr 2019

Thanks!

Add a Comment

Login with GitHub to post a comment