[#23591] - [4.0][com_config] Fixed sending the test mail
- Fixed in Code Base
- 27 Feb 2019
- Medium
- Build: 4.0-dev
- # 23591
- Diff
- roland-d:fix-configuration-test-mail
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Summary of Changes
Currently when you want to send out a test mail you get a notice that it is not possible because mail sending is disabled, even though it is enabled. Added the lost language strings as well.
Testing Instructions
- Make sure you have a Joomla 4 installation
- Click on System in the menu
- Click on Global Configuration
- Click on the Server tab
- Make sure that Send Mail is enabled
- Click on Send Test Mail
- Notice you get a message saying that mail sending has been disabled:
- Apply the patch
- Run the
npm ciin the Joomla folder to generate the updated files - Click Send Test Mail
- Notice that the test email has been sent
I may need help to correctly generate all JS files, so if there is any issues please let me know.
Expected result
That the test email is send when mail sending is active
Actual result
The test email is not send when mail sending is active
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings JavaScript Repository Front End Templates (site) |
Hello @ChristineWk Not being able to execute the test instruction isn't really an invalid test ;)
Have a look at J4 Setting Up your Local Environment and see if that helps. This npm stuff is needed for many PRs so it is handy to have.
| Labels |
Added:
?
?
|
||
Hi @roland-d I feared it :-)
delete from above URL the: ]. Site is empty. Found: https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment/en
You are right - but it's difficult :-) Thank you for info and understanding. Can or should I delete the "unsuccessfully"?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23591.
@ChristineWk Test seems to have been removed already, all is good and link is fixed. Thank you.
Rebooted drone at: http://ci.joomla.org/joomla/joomla-cms/13804
| Category | Administration Language & Strings JavaScript Repository Front End Templates (site) | ⇒ | Administration Language & Strings JavaScript Repository NPM Change |
I have tested this item
Hi,
fix about mailonline is ok and I tested successfully, but I had to force $tls=false in library /vendor/phpmailer/phpmailer/src/PHPMailer.php, just before if instruction at row n. 1945, to send mail correctly. Its my smtp server fault.
In joomla 3.9 staging I have option "SMTP Security" option set to "None" to let it work. I set to "None" in Joomla 4 dev too, but to send the email I need to force $tls value to false. I think is something about SMTPAutoTLS functionality.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23591.
I have tested this item
Hi,
fix about mailonline is ok and I tested successfully, but I had to force $tls=false in library /vendor/phpmailer/phpmailer/src/PHPMailer.php, just before if instruction at row n. 1945, to send mail correctly. Its my smtp server fault.
In joomla 3.9 staging I have option "SMTP Security" option set to "None" to let it work. I set to "None" in Joomla 4 dev too, but to send the email I need to force $tls value to false. I think is something about SMTPAutoTLS functionality.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23591.
| Labels |
Added:
NPM Resource Changed
|
||
Tested on launch.joomla.org where the message is displayed correctly, but I don't get the test email. Should this still be considered a successful test?
| Title |
|
||||||
I have tested this item
Works fine. tested with smtp.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23591.
rebooted drone.we will see.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23591.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-27 18:21:15 |
| Closed_By | ⇒ | wilsonge |
Thanks!
There is still something wrong here, It's not possible to connect to SMTP server without any SSL/TLS because $SMTPAutoTLS in the PHPMailer class is always true and not managed in any way by the mail class or Joomla options.
@joeforjoomla please open a new Issue and set a link here.
I have tested this item? unsuccessfully on bb3aa23
Confirm testing instructions, except for:
9. Run the npm ci in the Joomla folder to generate the updated files
That's why Tested unsuccessfully? sorry :-)
Do I hv to install e.g. https://docs.npmjs.com/cli/ci.html?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23591.