Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23586] - [4.0][com_csp] fix install sql menu

? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
18 Jan 2019

Pull Request for Issue #23359

Summary of Changes

fix sql for com_csp menu

Expected result

com_csp available under
screenshot from 2019-01-18 17-55-36

Actual result

not available

avatar alikon alikon - open - 18 Jan 2019
avatar alikon alikon - change - 18 Jan 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jan 2019
Category ⇒ SQL Installation Postgresql
avatar alikon alikon - change - 18 Jan 2019
Labels Added: ?
avatar twister65
twister65 - comment - 20 Jan 2019

I have a mysql error if I try to insert a datetime with '0000-00-00 00:00:00'

The DATETIME type is used for values that contain both date and time parts. MySQL retrieves and displays DATETIME values in 'YYYY-MM-DD HH:MM:SS' format. The supported range is '1000-01-01 00:00:00' to '9999-12-31 23:59:59'.

https://dev.mysql.com/doc/refman/5.7/en/datetime.html

INSERT INTO i05k8_menu(id, menutype, title, alias, note, path, link, type, published, parent_id, level, component_id, checked_out, checked_out_time, browserNav, access, img, template_style_id, params, lft, rgt, home, language, client_id) VALUES (23, 'main', 'com_csp', 'Content-Security-Policy', '', 'Content-Security-Policy', 'index.php?option=com_csp', 'component', 1, 1, 1, 36, 0, '1000-01-01 00:00:00', 0, 0, 'class:associations', 0, '', 41, 42, 0, '*', 1)

avatar twister65
twister65 - comment - 20 Jan 2019

I have tested this item ✅ successfully on 1840d88

With check_out_time '1000-01-01 00:00:00'.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23586.

avatar twister65 twister65 - test_item - 20 Jan 2019 - Tested successfully
avatar twister65
twister65 - comment - 21 Jan 2019

With MySQL strict mode enabled, which is the default state, invalid or missing data may cause warnings or errors when attempting to process the query.

With strict mode set (default from MariaDB 10.2.4), the statements will fail, and an error will be returned instead.

If strict mode is enabled, '0000-00-00' is not permitted and inserts produce an error.

https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html

avatar robertolongo robertolongo - test_item - 23 Feb 2019 - Tested successfully
avatar robertolongo
robertolongo - comment - 23 Feb 2019

I have tested this item ✅ successfully on 8f194dd

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23586.

avatar lucasacchiricciardi lucasacchiricciardi - test_item - 23 Feb 2019 - Tested successfully
avatar lucasacchiricciardi
lucasacchiricciardi - comment - 23 Feb 2019

I have tested this item ✅ successfully on 8f194dd

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23586.

avatar faustonenci faustonenci - test_item - 23 Feb 2019 - Tested successfully
avatar faustonenci
faustonenci - comment - 23 Feb 2019

I have tested this item ✅ successfully on 8f194dd

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23586.

avatar zero-24
zero-24 - comment - 23 Feb 2019

I have just rebooted drone so hopefully our bots are getting all happy to and this can finally be merged :D

http://ci.joomla.org/joomla/joomla-cms/14878

avatar Quy Quy - change - 23 Feb 2019
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 23 Feb 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23586.

avatar zero-24
zero-24 - comment - 23 Feb 2019

Drone is now happy too so this is ready to be merged cc @HLeithner and @wilsonge thanks to all the testers and code writers 👍

avatar HLeithner HLeithner - change - 23 Feb 2019
Labels Added: ?
avatar wilsonge
wilsonge - comment - 27 Feb 2019

Is there a reason this should be in the main user menu and not just in system administration? As a general rule of thumb i think anything that's user content should be in the menu which this isn't

avatar brianteeman
brianteeman - comment - 27 Feb 2019

I agree with @wilsonge this should find a home in the system control panel

avatar alikon
alikon - comment - 28 Feb 2019

well, with this logic Joomla! update too should look for a new home

avatar alikon alikon - close - 28 Feb 2019
avatar alikon alikon - change - 28 Feb 2019
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-02-28 19:43:26
Closed_By ⇒ alikon
avatar brianteeman
brianteeman - comment - 28 Feb 2019

@alikon #23760 (comment)

Add a Comment

Login with GitHub to post a comment